search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

Fixed issue where coverage was displayed for wrong file #120

Closed spodym closed 6 years ago

spodym commented 6 years ago

I am working on python project and your extension @ryanluker is helping me a lot!

Unfortunately big chunk of logic is inside __init__.py files. This extension has a bug that results in picking wrong coverage section to display in editor. This PR is my idea of fixing this bug.

ryanluker commented 6 years ago

hey @spodym thanks for the pull request 😄 . I will take a look and give you some feedback tonight!

ryanluker commented 6 years ago

@spodym Finished reviewing the pull request, looks pretty good overall! Let me know what you think about the few questions I left behind.

spodym commented 6 years ago

@ryanluker I fixed your suggestions. BTW. I think npm-shrinkwrap.json shouldn't be in the repository. That's my intuition but I am not familiar with node projects ;)

ryanluker commented 6 years ago

@spodym yes usually you dont commit the npm-shrinkwrap.json but in node 8 and later when you do npm shrinkwrap it generates a npm package lock file which is usually committed to the repository. https://docs.npmjs.com/files/package-lock.json

ryanluker commented 6 years ago

@spodym thanks again for the pull request 👍 . I am planning on a 2.0 release in the coming weeks so this fix will go out with that!

spodym commented 6 years ago

Great! :)