search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

Add simple cache. #122

Closed spodym closed 6 years ago

spodym commented 6 years ago

Hi @ryanluker !

Every switch between tabs is running extraction. I am working with quite big coverage file and this results in considerable lag in displaying coverage. After a while this becomes mildly distracting.

I've seen that you are planning to add some caching in future but please consider this PR as intermediate solution.

ryanluker commented 6 years ago

@spodym thanks for the pull request. I dont mind pulling this in and making a dev release of the extension (I would generate an .vsix file and attach it to the github release that you would manually install https://code.visualstudio.com/docs/editor/extension-gallery#_install-from-a-vsix). I am hesitant to do a marketplace release as the amount of overhead in terms of scheduling testing and then deploying would be too high when I am close to finishing the new architecture. How does the dev release option sound to you?

spodym commented 6 years ago

I agree that it might not be worth doing marketplace release. Besides in meantime I have managed to install my branch locally so I am good. I am not sure if anyone else would benefit from this dev release so I leave decision up to you.

BTW. If you need a hand with testing or developing new version - I would be happy to help :)

ryanluker commented 6 years ago

@spodym good to hear you got this working locally, I will close this for now instead of merging it in. Thanks, as well, for the offer of help :smile: once I get the tasks broken down and fleshed out a bit more I will find one for us to collaborate on!