search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

Show coverage only to files that match exactly #145

Closed jjuzna closed 6 years ago

jjuzna commented 6 years ago

Added logic to show coverage only to files that match exactly (new configuration option matchNameExact)

ryanluker commented 6 years ago

@jjuzna thanks for putting up a PR! This seems like a good addition but I wonder if we could use a number instead so that way people can decide their threshold for correctness. In addition to that change, we could also use some new tests to cover that the topSection properly ignores some scores based on the config store.

jjuzna commented 6 years ago

I have no problem with numbers. About tests - sorry I am writing this code in notepad++ and do not have running environment, therefore I cannot execute tests. My contribution has started as updates to extension js source (version 2.0.1).

ryanluker commented 6 years ago

@jjuzna closing this PR as we are going away from score based logic in favour of relative paths, thanks for putting the effort in though!