search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

convertPartialPathsToAbsolute optimization #230

Closed jjuzna closed 5 years ago

jjuzna commented 5 years ago

Added caching for glob search so that filesystem operations are done only once per watch not once per section.

ryanluker commented 5 years ago

@jjuzna I will try to get the QA done later this week and merge it in once done.

One thought I had was around if the glob search is even useful anymore (I guess for cases where the filename doesn't have a workspace in it)?

I will confirm the current glob search situation / scenario when I complete the QA.

jjuzna commented 5 years ago

@jjuzna I will try to get the QA done later this week and merge it in once done.

One thought I had was around if the glob search is even useful anymore (I guess for cases where the filename doesn't have a workspace in it)?

I will confirm the current glob search situation / scenario when I complete the QA.

My first commit reduced the number of glob search to 1, and second one to 0. If editor file is not in any workspace folders the coverage is not shown (it works the same as before).

Glob is now used only to find coverageFiles & reports.

ryanluker commented 5 years ago

@jjuzna I checked this out locally and everything looks good! This will go out with the 2.4.1 release. I have included the extension bundle below encase you want to use it ahead of time. vscode-coverage-gutters-2.4.0-letsplay.zip