ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

Random one pixel gaps in gutter #240

Closed tiffany352 closed 4 years ago

tiffany352 commented 4 years ago

Describe the bug Sometimes there is a one pixel gap between two lines in the gutter.

To Reproduce Steps to reproduce the behaviour:

  1. Have a high DPI monitor. I was able to reproduce with both 125% scaling and with 200% scaling in Windows.
  2. Open a file with coverage information.
  3. Scroll until you see a one pixel gap.

Expected behaviour There should ideally not be any gaps.

Screenshots image

Desktop (please complete the following information):

ryanluker commented 4 years ago

@tiffany352 Thanks for the issue! The decorator feature (which is used to show code coverage in the gutter) is provided by microsoft via the vscode api. I will have to look through the vscode issues to see if there is something similar to this has been brought up before.

You could also try using the line coverage option to see if the 1 pixel gaps exist there as well... https://github.com/ryanluker/vscode-coverage-gutters/blob/master/package.json#L107-L121 You will need to change the above settings in your vscode settings.json. https://code.visualstudio.com/docs/getstarted/settings

Let me know if that helps any in the meantime!

tiffany352 commented 4 years ago

It looks like the line coverage option produces both gaps and overlaps:

image

ryanluker commented 4 years ago

@tiffany352 thanks for the further information, I have finished looking through the vscode issue backlog and noticed something similar happening to another user https://github.com/microsoft/vscode/issues/82232#issuecomment-541055688 . Based on the explanation given there, it is definitely a vscode issue so I will close this ticket but I encourage you to raise this in the main vscode repository as the more :eyes: on this might spur microsoft to action!