search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

Read multiple tests for the same file in one coverage report #246

Closed justarandomgeek closed 4 years ago

justarandomgeek commented 4 years ago

This fixes #245 for me.

ryanluker commented 4 years ago

@justarandomgeek thanks for the PR! This is interesting, I assumed that the section returned from the different parsers (cobertura, lcov parse, clover, etc) would be unique per file and not greater then 1. Do you have an example lcov file that I can take a look at that shows this?

We should also add some integration test coverage to cover this new feature! I can assist with a bit of the coding later next week if you dont get to fixing the linting and the additional test coverage.

justarandomgeek commented 4 years ago

Sure, here's a file produced by my Factorio Mod coverage tool: it's separated out by test name and the Lua instance in which the script ran during that test, which i've sort of bodged together into a composite test name for lack of a better place to put the Lua instance name. The same file might sometimes run in multiple different Lua instances, and obviously different tests can go back over all the same files!

https://gist.github.com/justarandomgeek/8660e0685276994165915bb3df2ca347

Also, at least one of your own examples has this: https://github.com/ryanluker/vscode-coverage-gutters/blob/master/example/node/lcov.info has 94 sections for "SF:./node/test.js" all with blank TN

I'm afraid my js/ts skill is probably not great enough to help much though - i just barely managed to hack this patch into working at all! :)

ryanluker commented 4 years ago

@justarandomgeek thanks for all the extra info! I should be able to take this away and finish it for yah :grin: .

Side discussion: It is very cool to see you use the extension for factorio mods, I have played the base game a bit and it is quite fun (seems to scratch that programming itch)! What is the name of the mod you are making?

ryanluker commented 4 years ago

@justarandomgeek I took your changes and moved them to a new branch here #247

justarandomgeek commented 4 years ago

The one that brought me here specifically was my Coverage Tester Mod, which i'm using to see if my tests (which will probably eventually grow into a generalized tester tool mod...) on ConMan are actually complete. I've got quite a few other mods on the factorio mod portal though, and you can see a few of their names in that lcov file!