ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages

https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters

MIT License

460 stars 88 forks source link

Make base glob configurable via coverageBaseDir #271

Closed amatosov-rbx closed 4 years ago

amatosov-rbx commented 4 years ago

Rational

On big workspaces (e.g. 12k directories, 74k files) recursive glob lookup ** is very time consuming. Currently there is no way to avoid it via configuration options. manualCoverageFilePaths is the only option, however it eliminates any kind of glob lookup, which is not desired.

Change

Introduce coverageBaseDir that allows users to fully customize lookup glob for coverage files It defaults to **, so existing behavior is not going to change.

amatosov-rbx commented 4 years ago

Converted to draft. #270 should go in first

amatosov-rbx commented 4 years ago

@ryanluker this PR is ready for review

amatosov-rbx commented 4 years ago

@ryanluker Do you have any updates on the 2.6.0 release date?

ryanluker commented 4 years ago

@amatosov-rbx I was hoping the last item from the milestone would get in but if it isn't by Sunday I will just go away with a release. https://github.com/ryanluker/vscode-coverage-gutters/milestone/31

ryanluker commented 4 years ago

@amatosov-rbx 2.6.0 should be out now! thanks again for the effort in adding / fixing this 😁 . https://github.com/ryanluker/vscode-coverage-gutters/releases/tag/v2.6.0

amatosov-rbx commented 4 years ago

@ryanluker Thanks for getting the release out and quick feedback on fixes and additions =)