search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

refactor: Creates new module for crash reporting #285

Closed Kaytbode closed 3 years ago

Kaytbode commented 3 years ago

A new file report.ts that handles all codes dealing with crash reporting and sentry init, was created in the extension directory.

The changes did not cause any side effects after running tests.

ryanluker commented 3 years ago

@Kaytbode thanks for the PR. To get the tests passing, I will need to merge my other one first then these should be working again. https://github.com/ryanluker/vscode-coverage-gutters/pull/283/

Once that happens please update your branch and then I will start a PR review for yah. Also, thanks once again for the contribution! It helps a ton keeping this project active and maintained for all 🦾 .

Kaytbode commented 3 years ago

@Kaytbode thanks for the PR. To get the tests passing, I will need to merge my other one first then these should be working again. #283

Once that happens please update your branch and then I will start a PR review for yah. Also, thanks once again for the contribution! It helps a ton keeping this project active and maintained for all 🦾 .

Ok. I appreciate the opportunity to be contributing to such a wonderful project. My pleasure

Kaytbode commented 3 years ago

@ryanluker Please take a look at my code. I cannot figure out why the tests are failing here, but passing on my local machine.

Kaytbode commented 3 years ago

@ryanluker I have resolved it, by enabling TSLINT on my code editor.

Kaytbode commented 3 years ago

@ryanluker Please take a look at my code again. I have effected the changes you mentioned.

ryanluker commented 3 years ago

@Kaytbode I can merge this in for you but once I gave the approval you should have been able to merge to the mainline branch as well?

Kaytbode commented 3 years ago

@Kaytbode I can merge this in for you but once I gave the approval you should have been able to merge to the mainline branch as well?

I was able to merge to my copy of the mainline branch. Are you saying I can merge to ryanluker/vscode-coverage-gutters directly?

ryanluker commented 3 years ago

@Kaytbode I guess you weren't able to merge to ryanluker/vscode-coverage-gutters even with the pull request being approved? I don't mind pushing the button but I was just curious 😁 .

Kaytbode commented 3 years ago

@Kaytbode I guess you weren't able to merge to ryanluker/vscode-coverage-gutters even with the pull request being approved? I don't mind pushing the button but I was just curious 😁 .

Oh ok.. I did not even try to...