Closed mattseddon closed 3 years ago
ryanluker
commented
3 years ago @mattseddon Thanks for the contribution! I will try to take a look at it over the weekend sometime. I have authorized builds in the meantime though so that you can take a look at the linting errors etc.
mattseddon
commented
3 years ago @mattseddon Thanks for the contribution! I will try to take a look at it over the weekend sometime. I have authorized builds in the meantime though so that you can take a look at the linting errors etc.
No worries, thought that I had checked that the linter passed before putting up the PR but obviously not. I would be happy to get a husky pre-commit hook running for you if that is something that you think would be valuable. I would move your tests to use the insiders build at the same time because then you can run the tests whilst developing inside of vscode.
Anyway, LMK if you think that would be valuable. If it is I'll raise a separate PR.
ryanluker
commented
3 years ago @mattseddon great thinking on both fronts! RE pre-commit: Good idea, I have utilized pre-commit before (https://pre-commit.com/) for some work python projects. Based on a quick google it appears husky is similar (https://github.com/typicode/husky)? If so it sounds like a good addition, I would also have it added to the dev container https://github.com/ryanluker/vscode-coverage-gutters/blob/master/.devcontainer/devcontainer.json#L24-L25 and maybe a mention in the readme around contributing 🤔
RE insiders build: That was also on my mental backlog so that sounds great to me!
I ran into an issue today whilst trying to update the colors of gutters' SVGs (same issue as detailed in #239).
These changes are designed to enable users to have permanently saved SVGs somewhere on disk.