search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

Enable headless linux build tests #317

Closed mattseddon closed 3 years ago

mattseddon commented 3 years ago

This PR was promised here: https://github.com/ryanluker/vscode-coverage-gutters/pull/314#issuecomment-851379606

It enables tests against a linux build in the CI and also adds commands and packages that make running the test suite from the command line inside of the devcontainer possible.

I tried to make everything available in the most elegant way possible but github actions always end up being ugly (at best). LMK what you think and if you would like to see anything changed.

Thanks @ryanluker 👍🏻

Note: If you accept these changes then the required / expected steps will needed to be updated under the repository settings (the way that the actions now work has changed the matrix names, there are other ways to solve that problem but this was my preference).

ryanluker commented 3 years ago

@mattseddon I have setup the new branch requirements correctly I believe 🤔. I assume this is what you meant by "repository settings".

I am planning to work on a ticket today so we will see! image

I also saw this linux option for the branch protection but I believe we want to use the headless option to get your improvements correct? image

mattseddon commented 3 years ago

@mattseddon I have setup the new branch requirements correctly I believe 🤔. I assume this is what you meant by "repository settings".

I am planning to work on a ticket today so we will see! image

I also saw this linux option for the branch protection but I believe we want to use the headless option to get your improvements correct? image

The options that you have set look right. It will be pretty obvious when you make a PR if they are not 👍🏻.

ryanluker commented 3 years ago

@mattseddon excellent thanks again for the contributions they help a ton! happy code coverages 😁.

mattseddon commented 3 years ago

@mattseddon excellent thanks again for the contributions they help a ton! happy code coverages 😁.

No worries, thank you for the extension. I've been using it for a long time now! Let me know which issue(s) you're working on and I'll try to pick off a different one over the next couple of week 👍🏻.

ryanluker commented 3 years ago

@mattseddon Thanks! I try to keep the issues backlog up to date so anything in there is valid to work on. Usually assign myself to ones I am actively thinking about or working on (currently https://github.com/ryanluker/vscode-coverage-gutters/issues/308 ).