ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

Improve test mocking by adopting sinon #321

Closed ryanluker closed 3 years ago

ryanluker commented 3 years ago

https://github.com/ryanluker/vscode-coverage-gutters/pull/320#discussion_r650550183 @mattseddon FYI from our discussion in the other PR, I will work on plugging away at fixing and refactoring the existing manual mocks.

Background

See the past discussion and examples section but this issue will track the refactoring and removal of the manual mocks from the test suite. While useful at the beginning when the codebase and test amount was small, they have not scaled well and it is apparent we need a better tool.

Prep Work

Refactor existing manual mocks

Past discussions and examples around mocking

https://github.com/ryanluker/vscode-coverage-gutters/pull/270 https://github.com/ryanluker/vscode-coverage-gutters/pull/218 https://github.com/ryanluker/vscode-coverage-gutters/issues/198