search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

Start adoption of chai's expect and sinon-chai plugin #323

Closed mattseddon closed 3 years ago

mattseddon commented 3 years ago

Addresses the second checkbox in #321 and gives a suggestion for addressing the 4th (Remove deprecated assert.equal usage assert.equal).

Adds sinon-chai, types and updates test/extension.test.ts to chai's expect style of assertions (reasoning detailed inline).

This is just a suggestion. LMK what you think.

mattseddon commented 3 years ago

@ryanluker ~if you're happy with leaving the addition of a test fixture (https://github.com/ryanluker/vscode-coverage-gutters/pull/323#discussion_r659126419) until next weekend then I'll go ahead and merge 👍🏻.~ Fixed this too.

Thanks for the questions. Led to some good improvements.

The reason that I was so quick to add skipLibCheck is because it is enabled at my day job (turns out for a different reason which needs fixed). I'll work through updating the rest of the test files to expect over the next couple of weeks.

ryanluker commented 3 years ago

@mattseddon you should be good to merge whenever! I believe with the contributor role you can do that on your own now as well 🤔.