search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

Could not find coverage file #353

Closed timthelion closed 2 years ago

timthelion commented 2 years ago

I'm not a node developer. Is it easy/reasonable to create a temp dir for testing? Currently, this isn't done in the test suit: https://github.com/ryanluker/vscode-coverage-gutters/blob/1fa499cf309b7771628bdf78d5e7970ee906ba96/test/files/filesloader.test.ts#L28 but should be both for the happy path and this unhappy one. Can someone help me with that? I don't even know how to interact with the fs in node ;)

timthelion commented 2 years ago

Weirdly, this doesn't actually fix it for me when I install the vsix file. But the new error message was enough for me to figure out which dir I had to add to the ignore list. Adding the bad directory to the ignore list did fix this and I think the PR is still totally valid.

ryanluker commented 2 years ago

@timthelion Thanks for the PR! I will hopefully have some time this weekend to review it for yeah and hopefully merge it into the next release. Definitely looks like an improvement though on the error message from a first glance 🤔.