search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

Add `tslib` as runtime dep #371

Closed ilharp closed 2 years ago

ilharp commented 2 years ago

https://github.com/ryanluker/vscode-coverage-gutters/issues/370#issuecomment-1120402680

According to typescriptlang.org, not using importHelpers "can result in code duplication if the same helper is used in many different modules". So use tslib might be a better solution.

The reason the unit tests are not failing is that unit tests use the development environment's node_modules when running.

Tested on my computer.

close #370

ryanluker commented 2 years ago

@ilharp How were you able to confirm the fix on your computer? I was going to try compiling the vsix and installing that locally, maybe 🤔.

ilharp commented 2 years ago

@ilharp How were you able to confirm the fix on your computer? I was going to try compiling the vsix and installing that locally, maybe 🤔.

  1. npm run build && vsce package and then unzip the generated vsix, and there is tslib in node_modules.

image

  1. And then install this vsix then it just worksâ„¢

image

ryanluker commented 2 years ago

@ilharp How were you able to confirm the fix on your computer? I was going to try compiling the vsix and installing that locally, maybe 🤔.

  1. npm run build && vsce package and then unzip the generated vsix, and there is tslib in node_modules.

image

  1. And then install this vsix then it just worksâ„¢

image

KK thanks! I thought that was the case so I confirmed locally your fix. Release is going out shortly.