Closed anishkny closed 1 year ago
Hmm not sure why this is failing. Seems to pass on my fork: https://github.com/anishkny/vscode-coverage-gutters/actions/runs/3462820220/jobs/5782213247
Hmm not sure why this is failing. Seems to pass on my fork: https://github.com/anishkny/vscode-coverage-gutters/actions/runs/3462820220/jobs/5782213247
Thanks for the PR @anishkny ! I think a recently visual studio code insiders change has broken the integration tests I have 🤔. This started occuring here in the nightly scheduled builds that we do. https://github.com/ryanluker/vscode-coverage-gutters/actions/runs/3484203088/jobs/5847104491
I will have to investigate when I get some free time next...
Thanks for the PR @anishkny ! I think a recently visual studio code insiders change has broken the integration tests I have 🤔. This started occuring here in the nightly scheduled builds that we do. https://github.com/ryanluker/vscode-coverage-gutters/actions/runs/3484203088/jobs/5847104491
I will have to investigate when I get some free time next...
Ok thanks. The error doesn't seem related. I will leave it with you. LMK in case of any feedback.
@anishkny There was an issue with the insiders vscode testing suite. I have fixed up the latest master to get around this issue, please update your branch when you can, and I can give it a final review (looking good though!)
@ryanluker Done. Synced my fork and re-ran CI. Seems to pass: https://github.com/anishkny/vscode-coverage-gutters/actions/runs/3509504510
@ryanluker Gentle ping to get this merged. I do not have write access.
@ryanluker Gentle ping to get this merged. I do not have write access.
Whoops forgot to hit the green go button hah...
Issue:
378
Changes: