search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
460 stars 88 forks source link

Support jacoco aggregate #405

Closed 7sean68 closed 1 year ago

7sean68 commented 1 year ago

closes #401

ryanluker commented 1 year ago

@7sean68 We might want to add "Multi-Module Java" to the example projects list in the README. https://github.com/ryanluker/vscode-coverage-gutters#officially-supported-languages-backed-by-tests-ran-nightly

7sean68 commented 1 year ago

can you please not merge it now?

7sean68 commented 1 year ago

something I need to check first

ryanluker commented 1 year ago

something I need to check first

Sure thing, I have just need hitting the "approve and run" button to get the CI workflow to run for yeah.

7sean68 commented 1 year ago

I added the example to readme. I also added a notice to the copied test files from an Apache repo can you check if everything is ok? It's ready now you can merge if everything is ok. Thanks for the wait 😄

ryanluker commented 1 year ago

I added the example to readme. I also added a notice to the copied test files from an Apache repo can you check if everything is ok? It's ready now you can merge if everything is ok. Thanks for the wait 😄

Excellent, I will try to take a final look within the next week.

7sean68 commented 1 year ago

I think Apache license is compatible with MIT license anyway. So, even if the example are shipped the notice is enough and it doesn't affect the whole repo being MIT ... BTW that's why I paused merging the first time. I had to contact the author of the repo as I discovered it wasn't licensed ... thankfully he added the license and I updated the files to add the notice to not cause any problems for the repo.

Thanks for the great work creating and maintaining this helpful project. I use it as a main extension in vscode for java development.

ryanluker commented 1 year ago

I think Apache license is compatible with MIT license anyway. So, even if the example are shipped the notice is enough and it doesn't affect the whole repo being MIT ... BTW that's why I paused merging the first time. I had to contact the author of the repo as I discovered it wasn't licensed ... thankfully he added the license and I updated the files to add the notice to not cause any problems for the repo.

Thanks for the great work creating and maintaining this helpful project. I use it as a main extension in vscode for java development.

Excellent, thanks for going that extra mile to get a license added! Great to hear that the extension is providing value for your development work, mission accomplished!

Thanks again for the contribution, this helps keep the project running smoothly.