Closed MylesJP closed 1 year ago
Interesting that the Windows build of this failed. It seems to pass all tests when I run 'npm run test' on my local machine after installing all dependencies so I think the logic with my change is correct. Any thoughts as to why that is?
Interesting that the Windows build of this failed. It seems to pass all tests when I run 'npm run test' on my local machine after installing all dependencies so I think the logic with my change is correct. Any thoughts as to why that is?
Sometimes pulling the vscode image from microsoft's website can fail, and it causes 1/3 build pipelines to implode. Usually I just hit the retry button as the CI minutes are free for open source projects (afaik hah).
Looking great, thanks for the contribution @MylesJP!
Description
Cleanup some to-dos around using more modern typescript array helpers.
Work
.filter()
to reduce number of if-statements and consolidated if-statements where possible..some()
rather than.find()
to determine if match exists, since we only need boolean return..some()
returns after first match.Documentation
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some