ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
464 stars 90 forks source link

Refactored filterLineCoverage() and filterBranchCoverage() in renderer.ts #406

Closed MylesJP closed 1 year ago

MylesJP commented 1 year ago

Description

Cleanup some to-dos around using more modern typescript array helpers.

Work

Documentation

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some

MylesJP commented 1 year ago

Interesting that the Windows build of this failed. It seems to pass all tests when I run 'npm run test' on my local machine after installing all dependencies so I think the logic with my change is correct. Any thoughts as to why that is?

ryanluker commented 1 year ago

Interesting that the Windows build of this failed. It seems to pass all tests when I run 'npm run test' on my local machine after installing all dependencies so I think the logic with my change is correct. Any thoughts as to why that is?

Sometimes pulling the vscode image from microsoft's website can fail, and it causes 1/3 build pipelines to implode. Usually I just hit the retry button as the CI minutes are free for open source projects (afaik hah).

ryanluker commented 1 year ago

Looking great, thanks for the contribution @MylesJP!