ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
454 stars 88 forks source link

Coverage "gutter" not showing, "line" and "ruler" OK #407

Closed denisrossetre closed 1 year ago

denisrossetre commented 1 year ago

Describe the bug

To Reproduce Steps to reproduce the behaviour:

  1. Open a file part of the coverage tests
  2. Click on the "Watch" status bar button
  3. The "watch" transforms into "X % coverage"
  4. The coverage markers show up in line and ruler forms, but not in gutter form.

I've checked the "coverage-gutters" output window, everything seems fine.

Expected behaviour

Coverage that displays in the gutter

Screenshots image Desktop (please complete the following information):

denisrossetre commented 1 year ago

The problem does not happen with a blank profile created with the "Python" defaults.

This hints at an incompatibility with another VS Code extension.

image

denisrossetre commented 1 year ago

I haven't been able to identify which extension causes the problem, I'm restarting work with a blank profile and will update if I find anything.

SimonKagstrom commented 1 year ago

The gutter line seen in your last image is much thinner than it used to be. I see this since (I think) the last vscode update, and it makes it very hard to use the gutter display to actually see the coverage.

Perhaps a separate issue, but making it wider would improve the usability again I think

denisrossetre commented 1 year ago

Thanks @SimonKagstrom . Btw @ryanluker, your extension is very useful to work on improving code coverage where it matters.

... and indeed the problem happened after the last VS Code updates. In the meantime, I added extra extensions. If I can find something more specific, I'll update this issue.

SimonKagstrom commented 1 year ago

The credit goes to @ryanluker for the extension :-)

ryanluker commented 1 year ago

@denisrossetre Thanks for the ticket! (And the shoutout @SimonKagstrom 👍🏻)

I do think we are on the right track here, and something new with the latest vscode has shrunk the available gutter space we have for decoration icons 😢. Even if I double the size of the svg width it doesn't do anything, sadly...

(Note: the gutter is actually a SVG file while the line and ruler are just hex colours)

Current svg width

Screenshot from 2023-05-12 15-13-15

Doubled svg width

Screenshot from 2023-05-12 15-17-29

vkbo commented 1 year ago

Well, in the new version of VSCode that arrived today, the wide gutter seems to be working again 😄

image

ryanluker commented 1 year ago

@vkbo interesting, maybe a regression in the vscode styling then 🤔 closing for now.