search

ryanluker / vscode-coverage-gutters

Display test coverage generated by lcov and xml - works with many languages
https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters
MIT License
464 stars 90 forks source link

Unideal keybinding conflicting with "comment out" #451

Open simplenotezy opened 2 months ago

simplenotezy commented 2 months ago

Describe the bug The shift+command+7 keybinding conflicts with the "comment out" keybinding. I would recommend it got changed - perhaps letting the user assign own keybindings, or using some that is not already in use: https://github.com/ryanluker/vscode-coverage-gutters/blob/master/package.json#L182-L184

ryanluker commented 2 months ago

@simplenotezy Thanks for the ticket! We have changed the default keybindings before as they usually come into conflict with different vscode defaults as they change over time. AFAIK you are able to modify these as per the documentation for the extension.

simplenotezy commented 2 months ago

@simplenotezy Thanks for the ticket!

We have changed the default keybindings before as they usually come into conflict with different vscode defaults as they change over time. AFAIK you are able to modify these as per the documentation for the extension.

Thanks! That's also what I ended up doing

ryanluker commented 1 month ago

@simplenotezy Thanks for the ticket! We have changed the default keybindings before as they usually come into conflict with different vscode defaults as they change over time. AFAIK you are able to modify these as per the documentation for the extension.

Thanks! That's also what I ended up doing

Excellent! I will leave this open for a bit, but probably the short term fix is more documentation 🤔.