search

ryanmaxwell / UIAlertView-Blocks

Category on UIAlertView to use inline block callbacks instead of delegate callbacks.
MIT License
425 stars 58 forks source link

Added UIAlertViewStyle #2

Closed obrhoff closed 10 years ago

obrhoff commented 10 years ago

I added the possibility to display a UIAlertView with a defined UIAlertViewStyle.

ryanmaxwell commented 10 years ago

Hi, thanks for the commits. However, I don't agree with the return of the object from the class method. This doesn't follow cocoa conventions for object ownership, which is important as I'm supporting ARC and non-arc, and the naming of a method in cocoa of huge importance to signify a transfer in ownership.

E.g. if a class method returns an object, it would be better suited to be +(instancetype)alertViewWith.... Also, when you add a suite of class methods that also replicate the same functionality as the initializers, you end up with a messy API.

The 2 class methods are really a simple convenience but further customizations are probably best done by creating an instance.