search

ryanmaxwell / UIAlertView-Blocks

Category on UIAlertView to use inline block callbacks instead of delegate callbacks.
MIT License
425 stars 58 forks source link

Call to show on main thread #8

Closed patoroco closed 10 years ago

patoroco commented 10 years ago

Ensure that the show method call is done on main thread. Sometimes it failed me because I was calling it on other thread.

I also prepare podspec to be updated on Cocoa Pods master repo, you only need to add tag 0.8.1 (this is a patch to your version) on your repo.

ryanmaxwell commented 10 years ago

Thanks. I appreciate the patch - but it's commonly accepted throughout the entire cocoa frameworks that UI code can only run on the main thread - so I tend to think that it's up to the calling code to be on the correct thread instead of performing a check here.

Apple could have just as easily done the same thing with their own class, but they didn't because it's your responsibility to call it on the main thread - and by adding this feature I think it may even lead to other head-scratchers such as wondering why some UI things are working and others aren't when you show an alert along side other UI code.