ryanmaxwell / UncrustifyX

Uncrustify utility and documentation browser for Mac OS X
Other
586 stars 44 forks source link

Official uncrustify default config file fails to import #11

Open JanX2 opened 11 years ago

JanX2 commented 11 years ago

The official uncrustify default config file fails to import:

An error occurred during import The value 'ignore' is not valid for the number value type required for the sp_before_template_paren option

ryanmaxwell commented 11 years ago

This would indicate to me an issue with the official config file rather than a fault with the app. A basic validation is performed on the options based on their type during import - and i've noticed errors in the "official" config files before with respect to values and duplicate definitions.

JanX2 commented 11 years ago

Just as with issue #10, it may not be the best way to just curl up and die. :)

ryanmaxwell commented 11 years ago

agreed. I'll change the failure to a warning that can be overridden

JanX2 commented 11 years ago

Great! Thank you!