ryanmaxwell / UncrustifyX

Uncrustify utility and documentation browser for Mac OS X
Other
586 stars 44 forks source link

Dependency 'frageria' is missing #21

Open alexhunsley opened 5 years ago

alexhunsley commented 5 years ago

When I do git submodule init and update, I get:

fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Clone of 'git@github.com:ryanmaxwell/Fragaria.git' into submodule path 'UncrustifyX/Frameworks/Fragaria' failed

I've submitted a PR that makes the README say the project is currently broken - might save other people some time.

ryanmaxwell commented 5 years ago

Hi Alex,

I can see the submodule repos at their respective paths, they're not private forks https://github.com/ryanmaxwell/Fragaria and https://github.com/ryanmaxwell/Sparkle Not sure why you couldn't clone them? Do you have private keys set up for Github, if not try changing them to https rather than git.

I haven't done any work on this project in quite a few years - the main issue was that Fragaria is a large dependency, and it was build using ObjC GC which was deprecated quite a few Mac releases ago.

Although it does look like their repo has some activity that updated it to ARC so it should be possible to update this project to remove any GC requirement.

Out of curiosity I tried to build master on this repo in the latest Xcode (10.1) on Mojave (10.14.1) with both submodules checked out, and it built and run with no errors. Could use some tweaks to work properly in dark mode but otherwise it wasn't in as much of a dire state as I imagined.

screen shot 2018-11-25 at 22 55 09