ryanmcalister / unotes

Unotes Visual Studio Code Extension. A markdown WYSIWYG notes editor.
MIT License
173 stars 22 forks source link

Feature Request: Upgrade tui.editor from version 2.5 to version 3.x #137

Closed kiyoka closed 1 year ago

kiyoka commented 1 year ago

Reasons to upgrade

  1. Because tui.editor 2.5 has a bug, so #134 cannot be implemented. tui.editor 3.2 does not have the same bug.
  1. The main focus of the tui.editor project has moved to tui.editor 3.x, so any problems in tui.editor 2.5 may not be fixed.

Required Work

  1. Follow the migration guide below. https://github.com/nhn/tui.editor/blob/master/docs/v3.0-migration-guide.md I believe it is better to actually do the work to see what kind of work will be involved.
kiyoka commented 1 year ago

I share the current status. A few problems remain, but it is mostly working with tui.editor 3.0.0.

https://github.com/kiyoka/unotes/commits/fix_issue_137.tmp1

Remaining issues:

kiyoka commented 1 year ago

Remaining issues:

kiyoka commented 1 year ago

Remaining issues:

kiyoka commented 1 year ago

All remaining issues have been cleared. I will use new Unotes for a while and if I have no problem using it, I will pull request it.

ryanmcalister commented 1 year ago

I'm going to close this since it's been released in v1.5.0