ryanmcalister / unotes

Unotes Visual Studio Code Extension. A markdown WYSIWYG notes editor.
MIT License
173 stars 22 forks source link

Upgrade tui.editor from version 2.5 to version 3.x (#137) #141

Closed kiyoka closed 1 year ago

kiyoka commented 1 year ago

Migrated to tui.editor 3.2.1 or higher. This fixed some bugs caused by older version of tui.editor.

Target Unotes version: 1.4.4

Description

Issue fixed by upgrading Tui.editor

This is a critical issue that prevents usability, so I fixed it.

Migration

I Follow the migration guide below. https://github.com/nhn/tui.editor/blob/master/docs/v3.0-migration-guide.md

Tested

Notice

tui.editor 3.2.0 has a fatal bug. https://github.com/nhn/tui.editor/pull/2729 This issue has been fixed in tui.editor 3.2.1, so we need to use 3.2.1 or higher.

kiyoka commented 1 year ago

@ryanmcalister I have committed. Here, try this.

  1. I have dropped codeblock support. The reason is that it conflicts with codeSyntaxHighlight plugin in tui.editor 3.x. If the formula drawn in codeblock with Katex's Plugin, codeSyntaxHighlight overwrites it and breaks it.

  2. character escape feature tui.editor 3.x seems to have a feature to escape (_). If you save a file before enclosing it in $$, it seems that (_) is converted to (\_). Latex strings enclosed in $$ previously do not seem to be converted even after reloading.

inline_katex
ryanmcalister commented 1 year ago

2. Latex strings enclosed in $$ previously do not seem to be converted even after reloading.

hmm, I'm still seeing the escaping of _ when I reload the note or switch between markdown.

ryanmcalister commented 1 year ago

Thanks for the PR. I really appreciate the work done here!