ryanmcdermott / clean-code-javascript

:bathtub: Clean Code concepts adapted for JavaScript
MIT License
91.24k stars 12.23k forks source link

Add another Korean translation #353

Open sbyeol3 opened 3 years ago

sbyeol3 commented 3 years ago

I found this repository and translated it to study for myself. There's already a Korean translation, but it's a little different from mine.

I hope my contribution will be added. thanks :)

jjangga0214 commented 3 years ago

but it's a little different from mine.

I'd like ask some questions.

P.S: I am also a native Korean as well. Consider describing the answer in Korean if you cannot, or feel really difficult to, explain a subtle difference in English. (But avoid it as much as possible for other people.)

sbyeol3 commented 3 years ago

reply to @jjangga0214

The existing translation is really good, but when I read it, I think there are some parts that have been removed for natural translation. In some ways, more paraphrases were added to my translation to make it easier to explain. If you are Korean, you will probably feel a little difference when you read it. 🤓 I think it depends on the reader which one is better. -> answer to 1~3

When I started translating, I didn't know that there was already a Korean translation. So when I read what has already been translated, I thought it would be a little difficult to send PR to the repo because the expression were slightly different. (Each translator has a slightly different style. 😇 ) -> answer to 4

In addition, some languages appear to have multiple translations. So I sent PR to add one more, not to remove the existing Korean translation. It means that it would be good for Korean developers to choose something that is easier to accept. -> answer to 5

I haven't translated much, so I'm not good at it. Thanks for your advice. :)