ryanmcgrath
commented
3 years ago Probably just need to swap that call to be retained then is all. Give it a shot and feel free to PR it? Good catch!
On Sat, Jul 3, 2021 at 19:17, Rui A. Rebelo @.***> wrote:
Problem:
When a message is sent from the web page to the WKWebView it generates a segmentation fault.
Versions:
- cacao 0.2.0, feature "Webview"
- rust 1.51.0
- OS-X Catalina on a Mac Mini
Steps to reproduce it:
On the webview_custom_message.rs example do this:
-
Insert this after line 71, on AppWindow:new() webview_config.add_handler("notify"); This will add an handler for javascript messages.
-
Change the html code on line 37 into this webview.zip webview.zip webview.zip This will send a message from the webpage to the handler abore. And will also generate an error.
I created a simple gist containing both the modified example and a Cargo.toml file to build it.
This error only hapens if the message is sent from the javascript page only. There will be no issue if the message is posted from the rust code, like this: webview_config.add_user_script("window.webkit.messageHandlers.notify.postMessage("loaded");", InjectAt::End, true);
On my debuging I found that the problem is generated on the exit of the on_message() function on file webview/class.rs. More specifically, if this line 52 is commented out the problem won't happen: line 52: // let body = NSString::from_retained(msg_send![script_message, body]); line 53: delegate.on_message(name.to_str(), "dummy body value" ); It is during the execution of objc_autoreleasePoolPop->objc_release for the body variable that the problem happens.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.
rrebelo62
Problem:
When a message is sent from the web page to the WKWebView it generates a segmentation fault.
Versions:
Steps to reproduce it:
On the webview_custom_message.rs example do this:
Insert this after line 71, on AppWindow:new()
webview_config.add_handler("notify");This will add an handler for javascript messages.Change the html code on line 37 into this
<body onload="window.webkit.messageHandlers.notify.postMessage('Page loaded');">This will send a message from the webpage to the handler abore. And will also generate an error.
I created a simple gist containing both the modified example and a Cargo.toml file to build it.
This error only hapens if the message is sent from the javascript page only. There will be no issue if the message is posted from the rust code, like this: webview_config.add_user_script("window.webkit.messageHandlers.notify.postMessage(\"loaded\");", InjectAt::End, true);
On my debuging I found that the problem is generated on the exit of the on_message() function on file webview/class.rs. More specifically, if this line 52 is commented out the problem won't happen: line 52:
// let body = NSString::from_retained(msg_send![script_message, body]);line 53:delegate.on_message(name.to_str(), "dummy body value" );It is during the execution of objc_autoreleasePoolPop->objc_release for thebodyvariable that the problem happens.