search

ryanmcgrath / cacao

Rust bindings for AppKit (macOS) and UIKit (iOS/tvOS). Experimental, but working!
MIT License
1.86k stars 69 forks source link

Why does only WebView implements 'fn did_load( &self,...)' with self as non-mut? #14

Closed rrebelo62 closed 3 years ago

rrebelo62 commented 3 years ago

All controls implement fn did_load( &mut self, ... with self as mutable within did_load()

However WebView is the only exception, it implements self as non-mutable in fn did_load( &self,...).

Is there a particular reason for this (e.g. fear of changes on non-UI threads)?

ryanmcgrath commented 3 years ago

Nope, 's probably just oversight on my part - WebView is actually the oldest control here as it was the first ever created, and being behind the feature flag I've definitely missed a change there once or twice.

rrebelo62 commented 3 years ago

Want me to fix it and PR it? :-)

ryanmcgrath commented 3 years ago

Def feel free!