Change calling function, wrap -> retain in NSString

[24seconds]

Hello, while I'm testing whether desktop notification works if I use cacao (testing in my cacao_playground repo), I found user_notifications/mod.rs has called deprecated function of NSString.

I looked up the file history and found that NSString once had a function wrap but it seems to be replaced into reatin function.

So I made a simple change :D

[ryanmcgrath]

Good catch! Will merge this when I have time. Would love a PR’d demo as well if you’re up for it. ;)

Signing can be confusing but isn’t too bad…

Thanks!

On Sat, Oct 23, 2021 at 21:20, 24seconds @.***> wrote:

Hello, while I'm testing whether desktop notification works if I use cacao (testing in my cacao_playground repo), I found user_notifications/mod.rs has called deprecated function of NSString.

I looked up the file history and found that NSString once had a function wrap but it seems to be replaced into reatin function.

So I made a simple change :D

---

You can view, comment on, or merge this pull request online at:

https://github.com/ryanmcgrath/cacao/pull/18

Commit Summary

• wrap -> retain in NSString

File Changes

• M src/user_notifications/mod.rs (2)

Patch Links:

• https://github.com/ryanmcgrath/cacao/pull/18.patch
• https://github.com/ryanmcgrath/cacao/pull/18.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[kkharji]

Yep just faced this issue too, thanks @24seconds

Signing can be confusing but isn’t too bad…

Oh my god, it is ... still going at it

[ryanmcgrath]

Appreciate the PR, but this wound up getting handled in merging the 0.3 branch. Closing!