ryanmcgrath / cacao

Rust bindings for AppKit (macOS) and UIKit (iOS/tvOS). Experimental, but working!
MIT License
1.8k stars 65 forks source link

Simplify CI, fix cargo test, and fix docstrings #45

Closed simlay closed 1 year ago

simlay commented 1 year ago

hey hey, saw some of the cool stuff with objc2 coming into this repo so I figured I'd throw in some help that's independent of the objc2 changes.

This PR updates:

I figure this will enable us to have tests and prevent things like #32 are less likely to happen.

ryanmcgrath commented 1 year ago

Huh, thought I responded to this via email.

Super appreciate this! It all looks good to me and I think just needs a formatting pass to satisfy the PR checks here. Happy to merge after that. :)

simlay commented 1 year ago

It all looks good to me and I think just needs a formatting pass to satisfy the PR checks here.

hmm. When I run cargo fmt locally, it changes a lot. This could be from the recent rust release or maybe there's something not obvious?

ryanmcgrath commented 1 year ago

shrug

Beats me - but it passes it now and that's good enough for me. I might go ahead and cut a new point release for this just so anyone looking at docs has your work here visible - and then I think 0.4 can be a target for objc2 PRs.

Seriously appreciate this PR!