search

ryanmcgrath / cacao

Rust bindings for AppKit (macOS) and UIKit (iOS/tvOS). Experimental, but working!
MIT License
1.85k stars 69 forks source link

Fix compiling for iOS #46

Closed ryanmcgrath closed 2 years ago

ryanmcgrath commented 2 years ago

Block off the animator proxy pieces for appkit/macos to fix iOS compiling. Animation support was exploratory to begin with, and the iOS APIs are different enough that they'd need some thinking through anyway.

ryanmcgrath commented 2 years ago

@madsmtm Curious if you have any idea offhand why cargo fmt would be giving inconsistent results - i.e, on my local machine it has no changes, yet CI here is complaining.

(The sheer number of files changed is also, admittedly, concerning, lol)

madsmtm commented 2 years ago

Nightly vs. stable rustfmt ;)

simlay commented 2 years ago

Nightly vs. stable rustfmt ;)

Huh. I am surprised by how much difference there is. Also, I like the rustfmt from stable more but I think that's because of the trailing commas on the last items in a struct/list/etc.

madsmtm commented 2 years ago

Huh. I am surprised by how much difference there is. Also, I like the rustfmt from stable more but I think that's because of the trailing commas on the last items in a struct/list/etc.

Did this in https://github.com/ryanmcgrath/cacao/pull/29#issuecomment-1179749602 because it matched the previous output better (~= smaller diff). See rustfmt.toml for the nightly features.

ryanmcgrath commented 2 years ago

Hmmm, amusingly enough I've never considered how linking something iOS-specific on a GitHub action would work. If anyone's got ideas or done it before I'm all ears, otherwise I'll have to take a look this weekend - made two basic attempts but I'm probably missing something hella obvious.

simlay commented 2 years ago

Hmmm, amusingly enough I've never considered how linking something iOS-specific on a GitHub action would work. If anyone's got ideas or done it before I'm all ears, otherwise I'll have to take a look this weekend - made two basic attempts but I'm probably missing something hella obvious.

= note: ld: framework not found UIKit
[123](https://github.com/ryanmcgrath/cacao/runs/7912338422?check_suite_focus=true#step:5:124)
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

This is a new CI error for me. I've not used the action-rs/cargo action for iOS targets but I have done stuff with cargo-bundle and some annoying environment variables in a Makefile.

ryanmcgrath commented 2 years ago

Closing since this was addressed/rolled in #48.