search

ryanmcgrath / cacao

Rust bindings for AppKit (macOS) and UIKit (iOS/tvOS). Experimental, but working!
MIT License
1.85k stars 69 forks source link

Add image support for uikit feature backends #48

Closed simlay closed 2 years ago

simlay commented 2 years ago

This builds off #46.

I wanted to add some simple tests so I added Image support for iOS/uikit and put a simple test in with cargo-dinghy. I'm trying to avoid too much of the objc for the future merge conflicts but some I'm sure will happen.

The image used in the test-data is the favicon from simlay.net because I didn't know what else to use.

ryanmcgrath commented 2 years ago

This is awesome! At a glance I don't see anything I'm concerned with, but I'll likely take another look tomorrow and then look at merging.

If this also makes it so I don't need to deal with #46 further then I'll close that once this gets merged as well.

ryanmcgrath commented 2 years ago

I've gone ahead and reviewed the objc2 PRs with the aim to try and get them merged, after which I think I'll merge this and the iOS fix (and cut a 0.4 most likely, just due to the objc2 changes).

That said, this could probably get merged sooner without too much hassle - just don't want to make too much extra work for @madsmtm existing PRs.

(Your work is, as always, appreciated greatly!)

ryanmcgrath commented 2 years ago

Merged - thanks again for all of this!