search

ryanmcgrath / wrench-js

Recursive file operations in Node.js
MIT License
435 stars 71 forks source link

No test suites to ensure your module works #5

Closed soggie closed 12 years ago

soggie commented 13 years ago

Hi, it'd be nice if you were to add in a test suite to your module so that your users can verify your module works with their environment just by running your tests.

ryanmcgrath commented 13 years ago

Hey there,

While I'd love to write test cases for every bit of software I write, I have a lot of projects I maintain as well as a day job. If I can find some time I'll write some, but that's about the best I can say right now. Pull requests are welcome. ;)

Out of curiosity, I'm inferring that this module didn't work for you, for some reason - mind detailing that reason?

soggie commented 13 years ago

Hi Ryan,

I totally understand. My dilemma is this - all npm modules that I pull in, is put under tight version control. Our team has our own ecosystem manager running that automatically downloads new versions of npm modules when they become available (part of our CI server). Our policy has always been to reject modules that don't have test suites written because we don't want to run the risk of a new version of npm module causing catastrophic failures in our product. All these are automated because we use quite a few modules (about 10+ and growing rapidly), so it'd be impossible for us to check each module by hand.

They work for me, so it's not a question of whether they work or not but rather whether I can integrate this module into our ecosystem or not.

I'll definitely try to help you out on this if I get some time this weekend. :)

Great work btw.

ryanmcgrath commented 13 years ago

Hi again,

Thanks for understanding and detailing your problem! That's an interesting bit of info - does make me wanna get test suites thrown in here, but I can't justify spending time on it until later this week. If you get something sooner feel free to pull request, otherwise I'll give it a whirl when I have a free moment - not like it'll take too long. shrug

Thanks as always,

ryanmcgrath commented 12 years ago

Noting on this issue for any interested parties - there is indeed a test runner and such now, but I don't have much spare time for this at the moment to finish this all up. If anybody would like to take a stab, be my guest!

soggie commented 12 years ago

I'm really interested in building a more useful file system library, so I might be contributing when I have the chance. Currently swarmed with my couchdb driver refactor, but will definitely keep an eye on this project!

ryanmcgrath commented 12 years ago

Closing out this issue, as there's now some test coverage. If I (or any other generous party) gets a chance to write some more, it'll be sweet.