search

ryanmcgrath / wrench-js

Recursive file operations in Node.js
MIT License
435 stars 71 forks source link

Update wrench.js #59

Closed aogriffiths closed 11 years ago

aogriffiths commented 11 years ago

Fixes a bug (not sure if has been reported).

copyDirRecursive calls itself from the rmdirRecursive callback when newDir exists. It should call itself with the original copyDirRecursive arguments, not the callback arguments.

Also fun.apply(thisArg, argsArray) expects argsArray to be an array (see here) but arguments is not an array (see here)

Very similar to pull request 56 (I wrote my code before I noticed danielholmes did a similar fix).

ryanmcgrath commented 11 years ago

Heeeey so yeah this looks fine let's merge this sure.

Only ~2 months late on my part. You rock.