search

ryanmcgreevy / ModelMaker

ModelMaker plugin of VMD
2 stars 1 forks source link

Stop ModelMaker if rosetta fails #28

Closed trudack closed 7 years ago

trudack commented 7 years ago

ModelMakers jobs % script does not quit if rosetta never started

for example because mpiexec is not installed or modelmaker looks for the wrong rosetta executable

Right now you have to kill model maker by hand if this happens.

ryanmcgreevy commented 7 years ago

In this commit I changed the behavior of launching Rosetta bash scripts and how the while loops work. This makes it so modelmaker should finish as soon as the bash script is done, regardless of whether it crashed or finished properly.

Also, I should mention, I think this can be done a better way using tcl Threads and error handling, but the default Tcl VMD ships with is not compiled with Thread support, so that is not an option yet.