Closed bingo-bonzai closed 3 years ago
Think this was fixed here: https://github.com/ryanmitchell/ti-ext-kitchendisplay/commit/def37888e1cdf888b8c634128b39e3614f4402b7
Don't forget to tag so it rolls into Marketplace. Current version there is still 2.0.1.
Done đ
Today updated KD to v 2.0.1 however order listing issue still persists. While the Marketplace shows v 2.0.2 this version is still not visible under TI->Admins->System->Updates. Is there a lag between tagging and visibility of an update in the TI's Updates section?
There is a lag. Does take some time, that said, my anomaly is different: update showed as needed, but it still said 2.0.1. I did not update. Left the system for quite a while, came back and the KD does display orders yet the Marketplace says 2.0.2 AND the installed extension says 2.0.1 AND the view shows orders. Not sure what is the truth!
Pls refer to my View settings snapshot in the issue description above. Do you see any discrepancies in the selected settings that may be causing this issue?
The 2.0.2 update should fix it. You can see the code changed in the commit and apply it yourself to see if it helps.
If not debug the issue and open a PR
On 26 Nov 2020, at 18:17, bingo-bonzai notifications@github.com wrote:
ï»ż Pls refer to my View settings snapshot in the issue description above. Do you see any discrepancies in the selected settings that may be causing this issue?
â You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.
Same update issue as updating to v2! Removing extension and attempted reinstall does not install 2.0.2. Did v2.0.2 actually get released? Looks like github shows release 2.0.2 2 hrs ago. Yet, 40 minutes ago I looked and github still said 2.0.1. Hmm. . . . .wait and eventually things will sync up.
Yes.
On 26 Nov 2020, at 18:58, roydeanjr notifications@github.com wrote:
ï»ż Same update issue as updating to v2! Removing extension and attempted reinstall does not install 2.0.2. Did v2.0.2 actually get released?
â You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.
I'm still looking into the update issue. I'll keep you posted.
The update / install process is not working. I am going to have to manually add the extension back to my site.
Strangest thing! Manually uploaded the latest download and the version reads v1.0.0! I look at the extension.json and it reads 2.0.2! Why would that be occuring? I cleared cache before uploading the latest release.
No idea how the updates work sorry.
On 26 Nov 2020, at 20:09, roydeanjr notifications@github.com wrote:
ï»ż Strangest thing! Manually uploaded the latest download and the version reads v1.0.0! I look at the extension.json and it reads 2.0.2! Why would that be occuring? I cleared cache before uploading the latest release.
â You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.
site
Same here....i tried checking update today again however 2.0.2 still didn't show up so tried to uninstall and install it. but its not installing 2.0.2, strange...
Sam may be able to throw some light on the Install logic, but i cant see him on this Repo.
@ryanmitchell will it make sense to merge this extension into the TI branch so that code maintenance and issue management would be easier. What do you say?
No, this is a standalone extension - we are trying to reduce core rather than add to it. Sam has nothing to do with Kitchen Display which is why he isnt here đ I'll release a v2.0.3 now to try and get it to update for you.
Interesting...... Here is something I noticed and a bit of my own experience. 1 - the releases are not in order....if you look at the release page, 2.0.2 is listed after 2.0.1. It seems that the release listed at the top is the one that is picked up by TI. But what do I know for sure?
2 - my experience with KD updating, on another install on my own development environment (which I have set up and TI does work), I removed the extension manually and copied from all different releases. None of the releases show correctly. In fact, when I look at the release in the json file and what appears on the extension page, they are not ever matching.
3 - in my development install, KD does not display any orders. Oddly, even while my site on a shared host does show orders. This case is odd because I copied the code from the shared host site that does show orders and placed in into the development site, still no orders.
I will see what happens when I update to the latest version. Thank you, Ryan for pursuing this with us!
Update reflects correctly in the Extensions list on the shared host site! Yay! And, orders still show in the KD View I created......
Update refects correctly in my development site! Yay! Orders do not show!
This is really weird. I did the same thing on my development site as I have always done on my shared host site: change the status of some existing orders to Received rather than enter new orders. I am about to enter some new orders on my dev site. I will report once that is completed.
Hmm.... New order on dev site does not show in the KD View.......I even created a new view and still no orders.
Youâd need to debug the query and work out the cause.
Itâs working ok for me in my environment.
Iâm sure there is an issue but you need to work out where itâs coming up.
On 27 Nov 2020, at 15:10, roydeanjr notifications@github.com wrote:
ï»ż Hmm.... New order on dev site does not show in the KD View.......I even created a new view and still no orders.
â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
I understand. That is the part of the development environment I have not perfected yet.
Anything in the error log?
On 27 Nov 2020, at 15:36, roydeanjr notifications@github.com wrote:
I understand. That is the part of the development environment I have not perfected yet.
â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ryanmitchell/ti-ext-kitchendisplay/issues/26#issuecomment-734888590, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMVOZPLLV6R5GJEGN2FYLSR7BPLANCNFSM4UDSEFRA.
No errors in the error log related to the query or anything with the KD.
Ryan, I have been walking through the debug process and for whatever reason, the index.php page under customerdisplay/views/summary is getting executed and I keep having to click Resume or press F9 to get the webpage to finish and render.
I removed the customerdisplay extension and that made the debugger open index.php from the root folder, interesting though, it seems the KD summary is not getting executed as the breakpoint I set on $getorders never does get executed.
Or, maybe my environment is not setup like it needs to be to facilitate debugging like I want.
Maybe remove the index.php - it should be index.blade.php now so the .php ones can be removed.
On 27 Nov 2020, at 18:27, roydeanjr notifications@github.com wrote:
ï»ż Ryan, I have been walking through the debug process and for whatever reason, the index.php page under customerdisplay/views/summary is getting executed and I keep having to click Resume or press F9 to get the webpage to finish and render.
I removed the customerdisplay extension and that made the debugger open index.php from the root folder, interesting though, it seems the KD summary is not getting executed as the breakpoint I set on $getorders never does get executed.
Or, maybe my environment is not setup like it needs to be to facilitate debugging like I want.
â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
In customerdisplay? Have you modified that?
Oh sorry misread. Yeah I probably need to update customer display for blade.
Just so Iâm clear. If you turn off customer display then kitchen display works fine?
On 27 Nov 2020, at 18:32, roydeanjr notifications@github.com wrote:
ï»ż In customerdisplay? Have you modified that?
â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
No, it still is not working. I opened controllers/summary.php and set a breakpoint on $getorders line. Then opened my browser to navigate to the View button, clicked it and still get a blank page. The debugger did not stop at the breakpoint. Nor did it open summary.php to even reflect that it was getting executed on the server.
I may not have the debugger set right, as the absolute path on the server is not being detected. I changed that and now I get the breakpoint encountered. I'll review this and get back to you.
Seems like stepping through the code, it never steps into foreach ($getOrders as $orderIdx => $order)
. I set a breakpoint at $runningdishes = [];
and the debugger never stopped at that line. I suppose suggesting that no orders were returned.
I am having a hard time finding the query that is being executed.
Its the $getOrders = ⊠line block
Comment out the if (x) $query-> lines until you get orders and thatâll help diagnose where the point of the issue is.
On 27 Nov 2020, at 19:47, roydeanjr notifications@github.com wrote:
Seems like stepping through the code, it never steps into foreach ($getOrders as $orderIdx => $order). I set a breakpoint at $runningdishes = []; and the debugger never stopped at that line. I suppose suggesting that no orders were returned.
I am having a hard time finding the query that is being executed.
â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ryanmitchell/ti-ext-kitchendisplay/issues/26#issuecomment-734965265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMVO2LXAS526OAADNDBM3SR764TANCNFSM4UDSEFRA.
Ah, ok, will do.
Commented all if (x) and still no orders. Tried changing roles, permissions, etc. and still no orders. Is it possibly a memory issue? Wouldn't an error be seen if the server is out of memory?
Doubt it will be memory.
Have you tried turning on error displays:
ini_set(âdisplay_errorsâ, âonâ)
On 27 Nov 2020, at 21:42, roydeanjr notifications@github.com wrote:
ï»ż Commented all if (x) and still no orders. Tried changing roles, permissions, etc. and still no orders. Is it possibly a memory issue? Wouldn't an error be seen if the server is out of memory?
â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
Have not. Interesting situation, using VSCode and running with debug, I get an exception about invalid payload, however, when I run without debugging I get a blank page.
Invalid payload is stopping the code at line 195 in vendor/laravel/framework/src/Illuminate/Encryption/Encrypter.php. Is that an anomaly while debugging?
in Encrypter.php line 195 at FatalErrorException->__construct('message' => '???', 'code' => '???', 'severity' => '???', 'filename' => '???', 'lineno' => '???', 'traceOffset' => '???', 'traceArgs' => '???', 'trace' => '???', 'previous' => '???')in HandleExceptions.php line 148 at HandleExceptions->fatalExceptionFromError('error' => '???', 'traceOffset' => '???')in HandleExceptions.php line 134 at HandleExceptions->handleShutdown()in HandleExceptions.php at Encrypter->getJsonPayload('payload' => '???')in Encrypter.php line 136 at Encrypter->decrypt('payload' => '???', 'unserialize' => '???')in EncryptCookies.php line 110 at EncryptCookies->decryptCookie('name' => '???', 'cookie' => '???')in EncryptCookies.php line 84 at EncryptCookies->decrypt('request' => '???')in EncryptCookies.php line 67 at EncryptCookies->handle('request' => '???', 'next' => '???')in Pipeline.php line 171 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:147-180}('passable' => '???')in Pipeline.php line 105 at Pipeline->then('destination' => '???')in Router.php line 683 at CoreRouter->runRouteWithinStack('route' => '???', 'request' => '???')in Router.php line 658 at CoreRouter->runRoute('request' => '???', 'route' => '???')in Router.php line 624 at CoreRouter->dispatchToRoute('request' => '???')in CoreRouter.php line 20 at CoreRouter->dispatch('request' => '???')in Kernel.php line 170 at Kernel->Illuminate\Foundation\Http{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:167-171}('request' => '???')in Pipeline.php line 130 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:128-136}('passable' => '???')in SaveSetting.php line 27 at SaveSetting->handle('request' => '???', 'next' => '???')in Pipeline.php line 171 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:147-180}('passable' => '???')in TrustProxies.php line 57 at TrustProxies->handle('request' => '???', 'next' => '???')in Pipeline.php line 171 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:147-180}('passable' => '???')in TransformsRequest.php line 21 at ConvertEmptyStringsToNull->handle('request' => '???', 'next' => '???')in Pipeline.php line 171 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:147-180}('passable' => '???')in ValidatePostSize.php line 27 at ValidatePostSize->handle('request' => '???', 'next' => '???')in Pipeline.php line 171 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:147-180}('passable' => '???')in CheckForMaintenanceMode.php line 63 at CheckForMaintenanceMode->handle('request' => '???', 'next' => '???')in Pipeline.php line 171 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:147-180}('passable' => '???')in Pipeline.php line 105 at Pipeline->then('destination' => '???')in Kernel.php line 145 at Kernel->sendRequestThroughRouter('request' => '???')in Kernel.php line 110 at Kernel->handle('request' => '???')in index.php line 53 at {main}()in index.php
I refresh the page and I get the blank page.
Donât think this is anything to do with KD and I donât use VScode sorry.
On 28 Nov 2020, at 16:04, roydeanjr notifications@github.com wrote:
ï»ż Have not. Interesting situation, using VSCode and running with debug, I get an exception about invalid payload, however, when I run without debugging I get a blank page.
Invalid payload is stopping the code at line 195 in vendor/laravel/framework/src/Illuminate/Encryption/Encrypter.php. Is that an anomaly while debugging?
If I encounter that error and then stop debugging I get this in the browser: (1/1) FatalErrorExceptionUncaught Illuminate\Contracts\Encryption\DecryptException: The payload is invalid. in /var/www/html/vendor/laravel/framework/src/Illuminate/Encryption/Encrypter.php:195Stack trace:#0 /var/www/html/vendor/laravel/framework/src/Illuminate/Encryption/Encrypter.php(136): Illuminate\Encryption\Encrypter->getJsonPayload(NULL)#1 /var/www/html/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(110): Illuminate\Encryption\Encrypter->decrypt('en', false)#2 /var/www/html/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(84): Illuminate\Cookie\Middleware\EncryptCookies->decryptCookie('pma_lang', 'en')#3 /var/www/html/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(67): Illuminate\Cookie\Middleware\EncryptCookies->decrypt(Object(Illuminate\Http\Request))#4 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(171): Illuminate\Cookie\Middleware\EncryptCookies->handle(Object(Illuminate\Http\Request), Object(Closure)
in Encrypter.php line 195 at FatalErrorException->__construct('message' => '???', 'code' => '???', 'severity' => '???', 'filename' => '???', 'lineno' => '???', 'traceOffset' => '???', 'traceArgs' => '???', 'trace' => '???', 'previous' => '???')in HandleExceptions.php line 148 at HandleExceptions->fatalExceptionFromError('error' => '???', 'traceOffset' => '???')in HandleExceptions.php line 134 at HandleExceptions->handleShutdown()in HandleExceptions.php at Encrypter->getJsonPayload('payload' => '???')in Encrypter.php line 136 at Encrypter->decrypt('payload' => '???', 'unserialize' => '???')in EncryptCookies.php line 110 at EncryptCookies->decryptCookie('name' => '???', 'cookie' => '???')in EncryptCookies.php line 84 at EncryptCookies->decrypt('request' => '???')in EncryptCookies.php line 67 at EncryptCookies->handle('request' => '???', 'next' => '???')in Pipeline.php line 171 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:147-180}('passable' => '???')in Pipeline.php line 105 at Pipeline->then('destination' => '???')in Router.php line 683 at CoreRouter->runRouteWithinStack('route' => '???', 'request' => '???')in Router.php line 658 at CoreRouter->runRoute('request' => '???', 'route' => '???')in Router.php line 624 at CoreRouter->dispatchToRoute('request' => '???')in CoreRouter.php line 20 at CoreRouter->dispatch('request' => '???')in Kernel.php line 170 at Kernel->Illuminate\Foundation\Http{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:167-171}('request' => '???')in Pipeline.php line 130 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:128-136}('passable' => '???')in SaveSetting.php line 27 at SaveSetting->handle('request' => '???', 'next' => '???')in Pipeline.php line 171 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:147-180}('passable' => '???')in TrustProxies.php line 57 at TrustProxies->handle('request' => '???', 'next' => '???')in Pipeline.php line 171 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:147-180}('passable' => '???')in TransformsRequest.php line 21 at ConvertEmptyStringsToNull->handle('request' => '???', 'next' => '???')in Pipeline.php line 171 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:147-180}('passable' => '???')in ValidatePostSize.php line 27 at ValidatePostSize->handle('request' => '???', 'next' => '???')in Pipeline.php line 171 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:147-180}('passable' => '???')in CheckForMaintenanceMode.php line 63 at CheckForMaintenanceMode->handle('request' => '???', 'next' => '???')in Pipeline.php line 171 at Pipeline->Illuminate\Pipeline{closure:/var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:147-180}('passable' => '???')in Pipeline.php line 105 at Pipeline->then('destination' => '???')in Kernel.php line 145 at Kernel->sendRequestThroughRouter('request' => '???')in Kernel.php line 110 at Kernel->handle('request' => '???')in index.php line 53 at {main}()in index.php
â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
Not sure whether it is a debugging issue or what, but I get similar behavior when I use PHPStorm to debug. I just don't see the issue as PHPStorm doesn't stop and show the code but it does stop. I have to hit F9 a few times to get the blank page. Seems odd that I have to hit F9 to keep the page loading. Why wouldn't it just load and stop at a breakpoint?
I donât use php storm either. Sorry - without an error message I canât help!
On 28 Nov 2020, at 19:34, roydeanjr notifications@github.com wrote:
ï»ż Not sure whether it is a debugging issue or what, but I get similar behavior when I use PHPStorm to debug. I just don't see the issue as PHPStorm doesn't stop and show the code but it does stop. I have to hit F9 a few times to get the blank page. Seems odd that I have to hit F9 to keep the page loading. Why wouldn't it just load and stop at a breakpoint?
â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
I stepped through some more and the line 140 and 144 unset($menuItems[$menuIdx]);
and I can watch as the array goes from some number down to 0. Then the line 149 checks the $menuItems array and if 0 just continues. It appears it is always counting down to 0 and thus continueing since there are no items.
I just commented out lines 149-152 and I get cards but no menu items displayed.
I can click a button and get it to change the status as well. So that part is working.
I am in controllers/summary.php.
Commenting out lines 134-145 I get details on the display.
Line 141-4 is being called where you have set categories on the view settings, but the menu item has no categories so it removes the item from the view as there is no category match
On 28 Nov 2020, at 20:00, roydeanjr notifications@github.com wrote:
I just commented out lines 149-152 and I get cards but no menu items displayed.
â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ryanmitchell/ti-ext-kitchendisplay/issues/26#issuecomment-735283721, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMVO34H5SJUANAE6CM75DSSFJEDANCNFSM4UDSEFRA.
I have all the categories selected.
What does this line actually compare: $menu->category_priority = $menuModel->categories[0]->priority;
?
I don't have my categories set to priority = 100.
Iâll look later. Itâs late on a Saturday night for me and I donât really want to work :)
On 28 Nov 2020, at 20:41, roydeanjr notifications@github.com wrote:
ï»ż What does this line actually compare: $menu->category_priority = $menuModel->categories[0]->priority;? I don't have my categories set to priority = 100.
â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
I understand. I am surprised you are still up until I remember it is Saturday night! LOL! Thanks for the input. Have a great rest of night and Sunday!
That did not help. Another thing I noticed, with all statuses selected, I only get one order; the one that is in prep. All other orders do not show. Additionally, when I tested each status, the orders show for each status, but the orders selected does not totally match the orders in the list. The following is the result of each status selection I made. I have 2 orders that are Received and one that is in Prep: All status -> 1 order (the one in prep) Received -> 3 orders Pending -> 1 order (the one in prep) Preparation -> 1 order (the one in prep) Delivery -> 1 order (the one in prep) Cancelled -> 1 order (the one in prep) Ready -> 1 order (the one in prep) Completed -> maximum number of orders
I know this is occurring because I have commented out lines 135-145, but something besides what I commented out is not working correctly.
Expected behavior: Kitchen Display View should show a list of orders as per the selected status filter.
Actual behavior: Kitchen Display View show's blank in spite of setting a valid order status filter. I have tried for all Statuses and as well as each specific status. It still does not list any orders.
Reproduction steps:
Version: v3.0.4.-beta 24.4
View Settings
Blank Kitchen Display view