ryanmitchell / ti-ext-kitchendisplay

Other
14 stars 9 forks source link

Items that are NOT assigned to a category can't be displayed #29

Closed BreakSecurity closed 3 years ago

BreakSecurity commented 3 years ago

Category fields is mandatory due to avoid #19

But in this way items with no category are left out.

Possible fix make category NOT mandatory but check if array is empty in the code.

ryanmitchell commented 3 years ago

If your view only wants items from certain categories then it shouldn’t show items with no category.

Unless I’m misunderstanding your view configuration.

On 11 Dec 2020, at 16:19, BreakSecurity notifications@github.com wrote:

 Category fields is mandatory due to avoid #19

But in this way items with no category are left out.

Possible fix make category NOT mandatory but check if is empty in the code.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

BreakSecurity commented 3 years ago

How can I setup no category but all items?

ryanmitchell commented 3 years ago

Don’t choose a category in the view?

On 11 Dec 2020, at 16:37, BreakSecurity notifications@github.com wrote:

 How can I setup no category but all items?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

BreakSecurity commented 3 years ago

Yes, but: immagine

BreakSecurity commented 3 years ago

If I force no category by quickly savings the new view (no validation is done on fields if you do quickly but nothing can be perfect 😂 )

count(): Parameter must be an array or an object that implements Countable
--
in Summary.php line 148
ryanmitchell commented 3 years ago

Cool. Will look into both issue next week.

On 11 Dec 2020, at 16:47, BreakSecurity notifications@github.com wrote:

 If I force no category by quickly savings the new view (no validation is done on fields if you do quickly but nothing can be perfect :) )

count(): Parameter must be an array or an object that implements Countable

in Summary.php line 148

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

BreakSecurity commented 3 years ago

My fix do NOT take in account fields validation stuff (reminder)