ryanmitchell / ti-ext-kitchendisplay

Other
14 stars 8 forks source link

Adding payment code to KD #30

Closed BreakSecurity closed 3 years ago

BreakSecurity commented 3 years ago

Here to you my first pull request. Fix #15

ryanmitchell commented 3 years ago

Well done!

My only change would be to add them as new line options rather than replacing the existing ones.

Could you change that please?

BreakSecurity commented 3 years ago

Done let me know ;)

ryanmitchell commented 3 years ago

Updated with what I had intended. If you're happy I'll merge

BreakSecurity commented 3 years ago

I would like to have the possibility to have both telephone and payment code because what is great about KD to me is the general overview it provides across several orders. Maybe we can take only 3 char of payment code and add it after total. STRIPE -> STR and so on. What do you think?

Or put in: line 2 -> time, total, payment code (various combo) line 3 -> address, phone (various combo + blank)

In this way is like line 2 orders info for kitchen mainly and in line 3 personal customer info for drivers mainly

ryanmitchell commented 3 years ago

Address is usually long which is why its by itself on a line, adding phone to it is a bad idea in my opinion. I personally dont see the value in payment code at all as its on all the order receipts we print out.

BreakSecurity commented 3 years ago

And if we add only the 3 chars payment code to the first line without removing anything (time phone total and code)? Or we can just leave in anew line that is off by default

ryanmitchell commented 3 years ago

Name can be quite long too. You can add it as options and I'll accept it, just dont remove or modify any of the existing options.

BreakSecurity commented 3 years ago

There is a way to return to c5e1b6e when it was in a new line? Or I should redo manually and commit?

ryanmitchell commented 3 years ago

I don't want another line - 3 lines is the right amount of real estate on screen.

ryanmitchell commented 3 years ago

Can you not push until you are done? I get a notification on every push so have about 15 emails so far :)

BreakSecurity commented 3 years ago

I am really sorry I am trying to revert back a delete action. Still new to git and I dunno how to push only to my git and not in the pull req. I think I will close this and redo from zero