search

ryanmitchell / ti-ext-kitchendisplay

Other
14 stars 9 forks source link

Fix no selected categories senarios #31

Closed BreakSecurity closed 3 years ago

BreakSecurity commented 3 years ago

Second PR ;) Fix #29 hopefully without breaking anything else

ryanmitchell commented 3 years ago

Added the ability to re-blank categories. Let me know if this works for you.

BreakSecurity commented 3 years ago

It still allow me to create a view with no locations selected with no category selected. If I select categories than it validate location field too.

For the rest it is ok

ryanmitchell commented 3 years ago

You never mentioned locations ;) Try the latest commit

BreakSecurity commented 3 years ago

At the moment is possible to create multiple view with the same name should we prevent this or is too much?

BreakSecurity commented 3 years ago

So for me is ok to merge like this. Thanks for the tips