search

ryanmitchell / ti-ext-kitchendisplay

Other
14 stars 9 forks source link

Added 2 Extra Buttons #53

Closed fieldofsheep closed 3 years ago

fieldofsheep commented 3 years ago

I found this useful to add 'Delay' Statuses so that if the café is overwhelmed they can quickly knock back the collection time to the end user.

ryanmitchell commented 3 years ago

Thanks for the PR.

3 buttons was an intentional choice as it fitted best with the layout /card sizing across screen sizes. I wouldn’t be keen to add more by default - you can always extend the extension as you need it.

fieldofsheep commented 3 years ago

Hey

I thought about that but if they don't need more buttons they can just turn them off anyway so it looks the same I've left the width the same as before.

I've found afew bugs I'm going to investigate with tasty igniter.

Cheers

Dean

On Sun, 13 Jun 2021, 07:13 Ryan Mitchell, @.***> wrote:

Thanks for the PR.

3 buttons was an intentional choice as it fitted best with the layout /card sizing across screen sizes. I wouldn’t be keen to add more by default

  • you can always extend the extension as you need it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ryanmitchell/ti-ext-kitchendisplay/pull/53#issuecomment-860160000, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYZLTGEDQ63O4PMPKF2CTDTSRD7TANCNFSM46TGGJHA .

ryanmitchell commented 3 years ago

Don’t think I would want to ship something that breaks the layout with one of the options enabled.

As I said - it’s easily extended on a per install basis if required by the developer.

On 13 Jun 2021, at 09:49, Dean L. @.***> wrote:

 Hey

I thought about that but if they don't need more buttons they can just turn them off anyway so it looks the same I've left the width the same as before.

I've found afew bugs I'm going to investigate with tasty igniter.

Cheers

Dean

On Sun, 13 Jun 2021, 07:13 Ryan Mitchell, @.***> wrote:

Thanks for the PR.

3 buttons was an intentional choice as it fitted best with the layout /card sizing across screen sizes. I wouldn’t be keen to add more by default

  • you can always extend the extension as you need it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ryanmitchell/ti-ext-kitchendisplay/pull/53#issuecomment-860160000, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYZLTGEDQ63O4PMPKF2CTDTSRD7TANCNFSM46TGGJHA .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.