ryanmoran / faux

Generates fakes for use in testing Go programs.
MIT License
3 stars 0 forks source link

Erroneous import statements #13

Closed ForestEckhardt closed 2 years ago

ForestEckhardt commented 2 years ago

When running go generate ./... on the following branch https://github.com/paketo-buildpacks/yarn-install/commit/f4c29ad6e769434444283f0948bc394d7ad8c390 I am getting a lot of anchore import statements that are not the correct libraries in particular anchore/sfyt/sbom and anchore/stereoscope/pkg/file

Tool information:

go version:go version go1.16.3 linux/amd6 faux --version:0.20.0

joshuatcasey commented 2 years ago

I see the same thing, this time in pip. 26f07d1.

% go version       
go version go1.18.1 darwin/amd64
% faux --version
0.21.0
% git rev-parse HEAD
26f07d17fffa1bdf5dee018ec0c804b11c512651
% go generate
% git status
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   fakes/dependency_manager.go
    modified:   fakes/entry_resolver.go
    modified:   fakes/executable.go
    modified:   fakes/install_process.go
    modified:   fakes/sbom_generator.go
    modified:   fakes/site_package_process.go

no changes added to commit (use "git add" and/or "git commit -a")
% git diff
diff --git a/fakes/dependency_manager.go b/fakes/dependency_manager.go
index ea3feb5..2196a52 100644
--- a/fakes/dependency_manager.go
+++ b/fakes/dependency_manager.go
@@ -1,6 +1,9 @@
 package fakes

 import (
+       "github.com/anchore/stereoscope/pkg/file"
+       "github.com/anchore/syft/syft/sbom"
+
        "sync"

        packit "github.com/paketo-buildpacks/packit/v2"
diff --git a/fakes/entry_resolver.go b/fakes/entry_resolver.go
index 991aef7..d7a7108 100644
--- a/fakes/entry_resolver.go
+++ b/fakes/entry_resolver.go
@@ -1,6 +1,9 @@
 package fakes

 import (
+       "github.com/anchore/stereoscope/pkg/file"
+       "github.com/anchore/syft/syft/sbom"
+
        "sync"

        packit "github.com/paketo-buildpacks/packit/v2"
diff --git a/fakes/executable.go b/fakes/executable.go
index 5603000..2f7f7a2 100644
--- a/fakes/executable.go
+++ b/fakes/executable.go
@@ -3,6 +3,8 @@ package fakes
 import (
        "sync"

+       "github.com/anchore/stereoscope/pkg/file"
+       "github.com/anchore/syft/syft/sbom"
        "github.com/paketo-buildpacks/packit/v2/pexec"
 )

diff --git a/fakes/install_process.go b/fakes/install_process.go
index 7e14a8a..81d9607 100644
--- a/fakes/install_process.go
+++ b/fakes/install_process.go
@@ -1,6 +1,11 @@
 package fakes

-import "sync"
+import (
+       "sync"
+
+       "github.com/anchore/stereoscope/pkg/file"
+       "github.com/anchore/syft/syft/sbom"
+)

 type InstallProcess struct {
        ExecuteCall struct {
diff --git a/fakes/sbom_generator.go b/fakes/sbom_generator.go
index 0781b4c..9117d8e 100644
--- a/fakes/sbom_generator.go
+++ b/fakes/sbom_generator.go
@@ -3,6 +3,8 @@ package fakes
 import (
        "sync"

+       "github.com/anchore/stereoscope/pkg/file"
+       "github.com/anchore/syft/syft/sbom"
        "github.com/paketo-buildpacks/packit/v2/postal"
        "github.com/paketo-buildpacks/packit/v2/sbom"
 )
diff --git a/fakes/site_package_process.go b/fakes/site_package_process.go
index 7743d95..b1e5762 100644
--- a/fakes/site_package_process.go
+++ b/fakes/site_package_process.go
@@ -1,6 +1,11 @@
 package fakes

-import "sync"
+import (
+       "sync"
+
+       "github.com/anchore/stereoscope/pkg/file"
+       "github.com/anchore/syft/syft/sbom"
+)

 type SitePackageProcess struct {
        ExecuteCall struct {
ryanmoran commented 2 years ago

This should be resolved in https://github.com/ryanmoran/faux/releases/tag/v0.22.0. Let me know if you are seeing otherwise.