search

ryanmpelletier / java-simple-quadtree

A quadtree written in Java. Supports insert, update, search, remove, and more! Plenty of unit tests and also a performance report to compare with a brute force method.
https://ryanp102694.github.io/java-simple-quadtree/
MIT License
9 stars 3 forks source link

change ints to doubles #3

Open neseleznev opened 5 years ago

neseleznev commented 5 years ago

First of all, thanks a lot for you work.

Concerning for instance geo-spatial applications, smallest subtree has size of 1x1 degrees, which may be too much. In my case all the objects were returned by QuadTree.search which in turn ruined the performance. Once I've changed x, y, w, h to double values (and estimated optimal maxLevels for my own), everything worked like a charm. I have no clue, why you've managed to do integers there.

Please, consider this tiny fruitful change. Thank you once again for the pretty scalable solution!

ryanmpelletier commented 5 years ago

You're welcome! Im very happy you've gotten some use out of it! I'm sure your change makes sense, but give me a couple days to go over it and think about it. I'd love to make it more useful to you!

Out of curiosity, can you tell me what you are using it for?

-Ryan Pelletier

On Fri, Dec 14, 2018, 12:09 AM Nikita Seleznev <notifications@github.com wrote:

First of all, thanks a lot for you work.

Concerning for instance geo-spatial applications, smallest subtree has size of 1x1 degrees, which may be too much. In my case all the objects were returned by QuadTree.search which in turn ruined the performance. Once I've changed x, y, w, h to double values (and estimated optimal maxLevels for my own), everything worked like a charm. I have no clue, why you've managed to do integers there.

Please, consider this tiny fruitful change. Thank you once again for the pretty scalable solution!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ryanp102694/java-simple-quadtree/issues/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AL1omSxJagz6YUtzH4aSP2BbNS_AwIqgks5u4zKKgaJpZM4ZS5Ta .