search

ryanmurakami / pluralsight-hapi-starter-code

Contains the starter code for the Building Web Applications with hapi course on Pluralsight.com.
http://www.pluralsight.com/courses/hapi-building-web-applications
9 stars 8 forks source link

Bootstrap #2

Closed nycdotnet closed 9 years ago

nycdotnet commented 9 years ago

Hi Ryan,

I think you may have forgotten to include Bootstrap in this. The presentation doesn't look right without adding that.

-Steve O

ryanmurakami commented 9 years ago

Hi Steve!

Thanks for the comment. I used Bootstrap when developing the course, but replaced it with custom styles which are in the public/css/stylesheet.css file.

What is your project looking like?

nycdotnet commented 9 years ago

Perhaps there was a merge problem of some sort. This is what I see after downloading a ZIP of the content of this repo and copying it into the folder (as a customer might do):

hapi-no-bootstrap

When I also copy the default Bootstrap and Boostrap theme CSS file and link in the stylesheet.css file, it looks the same as in your video.

@import "bootstrap.css";
@import "bootstrap-theme.css";
ryanmurakami commented 9 years ago

Ah, yeah, that does look unstyled. I think the issue is the include statement in the templates/index.html file. The path to the stylesheet is setup for module 2 when we enable a static asset endpoint in our web server. If you change "assets" to "public" on line 4 of templates/index.html, it should enable you to see the styled version when viewing from your file directory.

I can see how this might be confusing when first looking at the files. I'll add a note to the readme about it.

Thanks!

ryanmurakami commented 9 years ago

@nycdotnet Thanks for taking the time to take those screenshots!

ryanmurakami commented 9 years ago

Actually, I spoke to soon! You're totally right, Steve, I left out some styles.... Pushing new code now. Thanks for the catch!

nycdotnet commented 9 years ago

No worries - will you take a PR to include HTML 5 doctypes and fix the unescaped ampersand on index.html? IE 11 barfs on that and renders in quirks mode.

ryanmurakami commented 9 years ago

I would love one! :-)