Cannot patch nerd font Meslo LGS with codicons

[hgoumner]

🗹 Requirements

• [x] I have searched the issues for my issue and found nothing related and/or helpful
• [x] I have searched the FAQ for help
• [x] I have searched the Wiki for help

🎯 Subject of the issue

Experienced behavior:

I cannot patch the nerd font Meslo LGS Regular with the codicons package due to the following error:

File "/home/hristo/Documents/nerd-fonts/font-patcher.py", line 1427, in <module> main() File "/home/hristo/Documents/nerd-fonts/font-patcher.py", line 1407, in main patcher.patch(sourceFonts[-1]) File "/home/hristo/Documents/nerd-fonts/font-patcher.py", line 302, in patch self.copy_glyphs(SrcStart, symfont, patch['SymStart'], patch['SymEnd'], patch['Exact'], patch['ScaleGlyph'], patch['Name'], patch['Attributes']) File "/home/hristo/Documents/nerd-fonts/font-patcher.py", line 956, in copy_glyphs currentSourceFontGlyph = min(possible_codes) ^^^^^^^^^^^^^^^^^^^ ValueError: min() arg is an empty sequence

This is the command i use: fontforge -script font-patcher.py MesloLGS\ NF\ Regular.ttf --custom codicon.ttf

And this is the structure of the directory as explained here

Expected behavior:

I expect to have a patched font being written in the directory.

Example symbols:

🔧 Your Setup

• Which font are you using (e.g. Anonymice Powerline Nerd Font Complete.ttf)?
  • Meslo LGS NF Regular.ttf
  • Where did you get the file from (download link, self patched, source downloaded from [link...)
    • From here
• Which terminal emulator are you using (e.g. iterm2, urxvt, gnome, konsole)?
  • Tilix 1.9.5
• Are you using OS X, Linux or Windows? And which specific version or distribution?
  • Linux Fedora 37

★ Screenshots (Optional)

I'm trying to set up the nvim-dap ui package which requires the codicons. This is what is currently being displaced with the wrong icons:

[Finii]

Sorry to hear of the problem, and thanks for the report. This looks like a real bug.

Just one question: You take an already patched font (Meslo LG M Regular Nerd Font Complete.ttf) and patch it again?

Anyhow I will try to reproduce.

[Finii]

Ah now I get it. The linked manual is 'old', codicons is now part of the normal (complete) Nerd Font patch set, so there is no need to do what you try to do.

Anyhow I will try to reproduce.

[Finii]

The script is confused by the .notdef glyph

Creating PR to fix.

Thanks again for reporting the bug.

And ... you do not need to self-patch, codicons are part of the Nerd Font set since v2.2.0. Although it's not the most current rev, but codicons 1.5, so maybe you want to do it anyhow. You will see the warnings, that patching has been skipped for most of the icons.

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.