ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
53.84k stars 3.63k forks source link

v2.3.2 Symbols-{1000,2048}-em Nerd Font Complete.ttf breaks layout #1069

Closed amezin closed 1 year ago

amezin commented 1 year ago

🗹 Requirements

🎯 Subject of the issue

Experienced behavior: After upgrade from v2.3.1 to v2.3.2, the layout of Firefox UI seems broken: in some places - a lot more whitespace than before, or text incorrectly offset to the bottom. Also affects some websites.

Removal/downgrade of the packages: ttf-nerd-fonts-symbols-1000-em or ttf-nerd-fonts-symbols-2048-em fixes the problem.

Expected behavior: No change after package upgrade

Example symbols: N/A. Lables without any special symbols are affected.

🔧 Your Setup

★ Screenshots (Optional)

GitHub

Before:

Screenshot from 2023-01-24 09-28-20

After:

Screenshot from 2023-01-24 09-25-40

Firefox tabs and address bar

Before:

Screenshot from 2023-01-24 09-28-54

After:

Screenshot from 2023-01-24 09-24-14

Firefox menu

Before (fits on screen):

Screenshot from 2023-01-24 09-22-21

After (doesn't fit on screen):

Screenshot from 2023-01-24 09-23-39

Finii commented 1 year ago

Do you have the 2.3.2-1 package (or without -1)? I wanted to download the package, can not find a download link quickly, maybe you have a tip?

Finii commented 1 year ago

I wanted to download the package, can not find a download link quickly, maybe you have a tip?

Found it ;-)

Finii commented 1 year ago

Ah I see...

The package needs a 2.3.2-2, will try to reach the maintainer.

Finii commented 1 year ago

@polyzen I guess you are the maintainer of ttf-nerd-fonts-symbols-2048-em

Can you please do a repackage of both Symbols Only fonts? You were too fast, I fixed a bug in the Symbols Only font right after release and changed the release zip file, but obviously not fast enough. Yes, I would normally have done 2.3.3 or 2.3.2-p1 release, but I thought I was ahead of the packagers ;-)

image

Finii commented 1 year ago

@amezin Do you know a better way to reach Daniel M. Capella?

Finii commented 1 year ago

:thinking: .o( I really really hate how the Nerd Fonts releases work )

If we can not sort this out 'soon' (whatever this means) I can push out a new release and hope that it triggers an automatic rebuild of the arch package.

amezin commented 1 year ago

@amezin Do you know a better way to reach Daniel M. Capella?

No.

I've opened a bug report in Arch Linux too: https://bugs.archlinux.org/task/77254

Finii commented 1 year ago

It breaks 'everywhere'. I noticed the problem right after release when the Nerd Fonts webpage used the new font and it was bOrkeN. That's why I fixed it immediately and (just) changed the archive file.

freswa commented 1 year ago

Hey, another ArchLinux maintainer here. I ran into this issue as well and woul like to help out. Though, we're loading the fonts from e.g. https://raw.githubusercontent.com/ryanoasis/nerd-fonts/v$pkgver/patched-fonts/NerdFontsSymbolsOnly/complete/Symbols-1000-em%20Nerd%20Font%20Complete.ttf where the archive doesn't really matter. Could you pull a 2.3.2.1 or 2.3.3 release please?

In my experience fixing bugs in releases is a rabbit hole. Better pull another release and keep the release of shame than trying to fix it. We run into this kind of things more often then we'd like to :)

Your efforts maintaining this repo are much appreciated. I love the font collection :+1:

Finii commented 1 year ago

Ok, let me fix the missing license files (code is like 10 years old), and then I re-release.

Finii commented 1 year ago

Release triggered, will take some hours.

freswa commented 1 year ago

@amezin Please check 2.3.3 in [community]

polyzen commented 1 year ago

@amezin Do you know a better way to reach Daniel M. Capella?

Pinging me on GitHub is sufficient, you could also use my email or IRC.

@amezin Please check 2.3.3 in [community]

@freswa, the packages didn't make it all the way to the repos, but that's resolved now. :p

Finii commented 1 year ago

See

amezin commented 1 year ago

ttf-nerd-fonts-symbols-2048-em 2.3.3-1 doesn't cause any issues now

Finii commented 1 year ago

:tada: Thanks for reporting back!

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.