ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.29k stars 3.64k forks source link

Victor Mono in Windows Terminal: some characters are very small #1080

Closed yogan closed 1 year ago

yogan commented 1 year ago

šŸ—¹ Requirements

šŸŽÆ Subject of the issue

I have downloaded the Victor Mono zip file the v2.3.3 release and tried to use it in Windows Terminal, which almost works, but a few characters are rendered very small.

Experienced behavior: Some letters are rendered way smaller than the rest for most font sizes. See screenshots below. I've noticed "fi" (ligature) and "g" (regular) in the italic "config" (for the non-italic, it's just the "g"). It also happens for "y". Some font-sizes are fine, e.g. 12 points and 16 points, but those are either too small or too large for my setup to be useable. The regular Victor Mono renders everything fine for e.g. 14 points (which is what I would like to use mostly).

Expected behavior: All characters should be rendered in the correct font size.

Example symbols:

šŸ”§ Your Setup

ā˜… Screenshots (Optional)

image

image

image

image Regular Victor Mono renders everything just fine, but of course the Nerd Font icons are missing.
"VictorMono NF" and "VictorMono NFM" seem to be exactly the same, "VictorMono Nerd Font" is even worse, the whole italics are not working for that one.
I've tried to install both the "Windows Compatible" variants, and the "regular" ones. I had no luck with both. :-(

Finii commented 1 year ago

I fear the family naming is the problem.

Can you remove as many VicotorMono fonts as possible? The less you have the better. Best would be just the plain old style set-of-4:

If that is the cause we can (easily) fix it.

It's important to test with just these 4 fonts (or the 4 Nerd Font Mono variants). For Windows do use the Windows Compatible fonts (at least for this test). Maybe reboot after changing (uninstalling and installing) the fonts; in some rare cases Windows does not detect changes in fonts I think.

yogan commented 1 year ago

Hi Finii, thank you for your instructions, I did some further testing based on that. Using only those four variants makes a lot of sense. Initially I was confused by the large amounts of fonts from the zip file and assumed "the more I install, the better" (though I only did with either the "Windows Compatible" set, or the others).

So here is what I have done now:

Note that I did not reboot in between, but I did close all instances of Windows Terminal. I think no reboot should be fine, as after uninstall, the fonts were no longer listed (both in Windows Terminal and the Win 11 control center font page). I did have both "Victor Mono" (original) and NFM4 installed after step 4 - not sure if that could have been an issue, but since my first set of tests with just NF4 (and no original) also showed issues, I don't think so.

What I have noticed: the effects are worse for some font sizes, and also more present in the italic version.

Something else that I noticed (which is a bit more subtle): in general the letters might be a bit too low, so sometimes the lower parts of letters like "p" and "g" get cut off. That's why I also included screenshots of a status bar with a colored background. When comparing to the original font, you can see that the baseline distance to the bottom is smaller for the patched font. The cutting of can be seen pretty good for "g" in 13 points: image vs image

So here are all of my results, I took three screenshots (regular, italics, and a statusbar with a background) for each of the three font variants (NF4, NFM4, original) in four font sizes.

Victor Mono {Regular,Italic,Bold,Bold Italic} Nerd Font Complete Windows Compatible

12 points

NF_12_regular NF_12_italic NF_12_statusline

13 points

NF_13_regular NF_14_italic NF_13_statusline

14 points

NF_14_regular NF_14_italic NF_14_statusline

15 points

NF_15_regular NF_15_italic NF_15_statusline

Victor Mono {Regular,Italic,Bold,Bold Italic} Nerd Font Complete Mono Windows Compatible

12 points

NFM_12_regular NFM_12_italic NFM_12_statusline

13 points

NFM_13_regular NFM_13_italic NFM_13_statusline

14 points

NFM_14_regular NFM_14_italic NFM_14_statusline

15 points

NFM_15_regular NFM_15_italic NFM_15_statusline

Victor Mono original

12 points

original_12_regular original_12_italic original_12_statusline

13 points

original_13_regular original_13_italic original_13_statusline

14 points

original_14_regular original_14_italic original_14_statusline

15 points

original_15_regular original_15_italic original_15_statusline

A-Lamia commented 1 year ago

Having similar issues where new versions (Repeated everything above) 2.3.3: image 2.3.0-RC: image

honestly I'm not sure what it is but most the fonts are also messed up on windows in both neovide, windows terminal and wezterm. All the same issue. like Symbols_NF straight up just doesn't work.

Finii commented 1 year ago

Thanks for reporting @A-Lamia !

Unfortunately in your very constructive critique you do not explain what the concrete issue is.

Maybe you mean the circled glyph image

that renders 1 cell wide in 2.3.3 and 2 cell wide in 2.3.0-RC. Which can mean that you think 2.3.0-RC is not broken, while 2.3.3 is broken, in that regard. Without any explanation it is hard to offer any help.

Anyhow, if it is about the powerline glyphs, they will be resized with 3.0.0:

rzabcio commented 1 year ago

I have the same problem with Windows Terminal. The biggest problem are "g" that looks like "q" at some sizes, and "_" which... dissappears completely, looking like space.

Everything is ok with original Victor Mono font.

Finii commented 1 year ago

@rzabcio To make it easier for me to reproduce: Where did you get the font files from, and did you install just one, some, or 'all' (whatever that means)?

rzabcio commented 1 year ago

I tried two sources, with the same effect.

(my main OS is Windows, but I work on VM through ssh on Windows Terminal)

I tried Windows Compatible version.

Finii commented 1 year ago

Did install this set of 4 on Windows 10:

image

Setting this up in Terminal:

image

And the result is ok (i.e. can not reproduce):

image

Italic was a bit harder ... ;-)

image

But what I noticed, that all the letters that seem to be affected in your setup are the ones that are cut off:

image

This could be an effect of Windows Terminal, because it scales too-big glyphs down. But why not on my machine?

I have Windows Terminal Version: 1.16.10261.0

Anyhow, I guess the cut-off problem is solved with v3.0.0, let me check...

Finii commented 1 year ago

Yes, no more cut off descenders:

image

I think there is quite a good chance that the problem will be fixed by that.

Finii commented 1 year ago
* community/**ttf-victor-mono-nerd 2.3.3-2** Arch Linux package

(my main OS is Windows, but I work on VM through ssh on Windows Terminal)

Maybe I'm too old :grimacing: but I think I do not understand that. I guess you installed the Arch package in the VM. But the Windows Terminal runs under Windows, so how does the fonts leak out of the VM into the host OS :thinking:

It's probably not a VM but this ominous Windows Linux Subsystem or how that is called. If you install a font in that Linux subsystem it will end up in the Windows font folder? :grimacing:

yogan commented 1 year ago

Nope, that is not how WSL works. Installing fonts in a WSL distro should have zero effect on the available fonts in Windows. It should have an effect on graphical Linux apps running via WSLg, but that's not the point here.

rzabcio commented 1 year ago

You are right, obviously, I just maden a huge shortcut i my description.

I use Arch on VMWare Workstation. I installed there above Arch package, found .ttf fonts in the filesystem, zipped them, scp-d them from the host Windows, installed it normally and finally selected it in Windows Terminal. That's the full path, sorry for unclear comment. :ā -ā )

Finii commented 1 year ago

Release is in repo, release as packages pending.

github-actions[bot] commented 11 months ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.