search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.89k stars 3.65k forks source link

Space Mono Ligature fi looks strange #1187

Closed Fxzzi closed 1 year ago

Fxzzi commented 1 year ago

🗹 Requirements

🎯 Subject of the issue

Experienced behavior: Ligatures should be shown with Space Mono NF. When typing 'fi' there is a space after and they are stuck together as shown here image

Expected behavior:

The ligatures for => and ==> are not included and / or shown using this font.

Example symbols:

->=> ==> fi

🔧 Your Setup

★ Screenshots (Optional)

image

Finii commented 1 year ago

Can you show your kitty conf?

Ah, if I remember correctly I was unable to turn on (?) any ligatures in kitty. Is there a trick?

Hmm, but even in Writer there seem to be no ligs?

image

otoh...

image

Finii commented 1 year ago

Ah, when looking on that...

The fi ligature is just one character wide. That is not supported by kitty. If you type two letters it has to occupy too cells. Kitty has very strong opinions about how things have to be and does not try to do what you might want.

Suggest: Use some other terminal.

Fxzzi commented 1 year ago

Ah, if I remember correctly I was unable to turn on (?) any ligatures in kitty. Is there a trick?

All ligatures are enabled by default in kitty.

Finii commented 1 year ago

You are right! :-)

image

Well, the fi and -> are encoded in the font to be just one cell wide, this is not supported by Kitty which is very unflexible. Probably the => has also not the expected-by-kitty width.

Compare Kovid's answer here

Note that in that concete issue the ligature IS exactly n chars long, but still ... must be a font issue :roll_eyes:

So.. Sorry. The font and the terminal are not compatible. You will have the same issue with the unpatched font.

Fxzzi commented 1 year ago

Any terminal you'd recommend? And a config for ligatures?

Finii commented 1 year ago

Personally I use tilix, because that does not assume anything about the font and allows everything (*). Which makes it 'dead slow' of course (will, I never dump megabytes of logfiles, so it does not matter. I know how to grep ;). I mainly use tilix for the tiling of course, and because I can sync-type in a multiple windows (I mean tiles). In this way I can sudo apt update on 20 machines in parallel for example.

And although I'm a command line person and was used to X configuration stuff (in 198x), I really like a terminal with a settings dialog and not a text file.

In total I have no clue which terms are good or bad. Kitty turns up in issues here often because of inflexibility. Maybe Tilda is also blanzingly fast - but I always have to self build because it does not work with my graphics cards :roll_eyes:

Before tilix I used Gnome terminal (laugh) and Terminator (you see speed is not my problem). My 'reason' for tilix is simple just the first tiling thing a found by ~change~ chance after terminator got problematic because of Python versions.

(*) Some years back I did couple of Erlang and other functional languages, and there proportional fonts are not seldom used. So a terminal that can run any (also proportional) fonts is what I like more.

Config for Ligs Well, maybe you can turn ligs off with Kitty, if that helps you. How, I don't know. My eyes always already glace over when I need to remember that shift-ctrl-f2 starts the settings (O_o)

Fxzzi commented 1 year ago

Wondering if this can be reopened. Regular apps which don't even support ligatures (as far as I know) are also experiencing the issue with the fi

See this screenie from dunst image

If you need any more info please do not hesitate to let me know

Finii commented 1 year ago

But that is how Space Mono is intended to look? See here on Google Fonts, the unpatched/original Space Mono:

image

You just need to turn ligatures off in your terminal.

Otoh, that lig is really ... bad looking. We could of course remove it on patching. But usually the patched fonts do not differ from the original, they just get more glyphs.

We can reopen...

Finii commented 1 year ago

Thanks for persisting there must be a bug :-D

@allcontributors please add @Fxzzi for bug

allcontributors[bot] commented 1 year ago

@Finii

I've put up a pull request to add @Thanks! :tada:

I've put up a pull request to add @Fxzzi! :tada:

github-actions[bot] commented 1 year ago

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.