search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.75k stars 3.65k forks source link

Add Fira Code's progress bars and spinner. #1345

Closed oshaboy closed 7 months ago

oshaboy commented 1 year ago

Requirements

Is your feature request related to a problem? Please describe. It's not a problem it's a request for more symbols from Fira Code.

Describe the solution you'd like I would like the Fira Code progress bar and spinner to be added to the font.

Describe alternatives you've considered The only fonts I know that support Fira Code's progress bar and spinner are Fira Code and Iosevka.

Additional context

Fira Code added glyphs for a progress bar and spinner in the PUA. Not much software support for them is out there. It feels like they should be glyphs in nerd fonts but they aren't.

oshaboy commented 11 months ago

Shouldn't this be added to #1095. I didn't know about that thread when I made this issue

Finii commented 11 months ago

It should, and it will ;-D And it is correct (best) to create this issue here. Direct adding to 1095 is not good.

At the moment I still work on the 3.1.x release which absorbs about 120% of the time I can allot for Nerd Fonts. Please bear with me.

mikesmithgh commented 11 months ago

Hey 👋, this is really nice. I am using Fira Code Nerd Font v3.1.0 and can see the spinners.

I modified test-fonts.sh locally for experimenting.

    echo "Nerd Fonts - Fira"
    print-unicode-ranges ee00 ee0b ee10 ee15
    echo
    echo

fira-nerd-fonts

I have a question around what this ticket actually means for implementation.

  1. Since I can see the symbols, does this mean that this is already implemented in v3.1.0 ? or
  2. Will this add these symbols be patched to all Nerd Fonts and maybe use another private-use unicode area?
Finii commented 11 months ago

Type fc-list :charst=ee00 and see where the icons come from. Nerd Font does not patch in anything at EE00, see https://github.com/ryanoasis/nerd-fonts/wiki/Glyph-Sets-and-Code-Points#overview

The spinners are originally in Fira (so if you use Fira or a patched version of it they are there). This Issue aims to ~steam~ steal them from Fira and put them in all fonts.

oshaboy commented 11 months ago

Yeah a lot of terminals if you don't have characters in the default font it tries fallback fonts.

mikesmithgh commented 11 months ago

Type fc-list :charst=ee00 and see where the icons come from. Nerd Font does not patch in anything at EE00, see https://github.com/ryanoasis/nerd-fonts/wiki/Glyph-Sets-and-Code-Points#overview

The spinners are originally in Fira (so if you use Fira or a patched version of it they are there). This Issue aims to ~steam~ steal them from Fira and put them in all fonts.

Thanks! 

fc-list ':charset=ee00' | grep Fira
/Users/mike/Library/Fonts/FiraCodeNerdFont-Regular.ttf: FiraCode Nerd Font:style=Regular

That makes sense, I am using Kitty and explicitly setting the symbol_map to FiraCode Nerd Font

I got excited when I saw these and didn't realize they were Fira exclusive. I look forward to you steaming stealing them 🙂

Finii commented 7 months ago

Closing because transferred to https://github.com/ryanoasis/nerd-fonts/discussions/1095