search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
54.57k stars 3.65k forks source link

Describe patcher family-name generation in readme #1362

Closed frantisekhanzlikbl closed 1 year ago

frantisekhanzlikbl commented 1 year ago

Description

updated the project's readme to mention that the font patcher CamelCases and removing whitespace from the resulting font's family names.

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

the change contains GitHub's alert syntax, which might not render in the preview, but should render in the actual readme. (ref: https://github.com/orgs/community/discussions/16925#discussioncomment-6879962)

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Finii commented 1 year ago

Thanks for the PR.

I'm not sure with the term "Family"... altough technically correct, maybe we should say just 'name' instead? For the not so expertly users? Or at least "Family name"?

Finii commented 1 year ago

@allcontributors pleas add @frantisekhanzlikbl for doc

allcontributors[bot] commented 1 year ago

@Finii

I've put up a pull request to add @frantisekhanzlikbl! :tada:

frantisekhanzlikbl commented 1 year ago

Thanks for the PR.

I'm not sure with the term "Family"... altough technically correct, maybe we should say just 'name' instead? For the not so expertly users? Or at least "Family name"?

That makes sense. I'd lean towards mentioning both, since at least for web devs, the term family is more widely used, I believe. What about the current patch, does that look OK?

Finii commented 1 year ago

What about the current patch, does that look OK?

Perfect. Thanks again.