search

ryanoasis / nerd-fonts

Iconic font aggregator, collection, & patcher. 3,600+ icons, 50+ patched fonts: Hack, Source Code Pro, more. Glyph collections: Font Awesome, Material Design Icons, Octicons, & more
https://NerdFonts.com
Other
53.79k stars 3.62k forks source link

Update nerd-fonts-generated.css #1365

Closed asteriskayush007 closed 11 months ago

asteriskayush007 commented 11 months ago

i update yours font weights, line heights, styles,etc

Description

Please explain the changes you made here.

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Finii commented 11 months ago

Thanks for the PR.

Maybe you can explain the reasons for the change? I'm intrigued to know why the weight is first 100 and then 300?

The file you change is a generated files. Any changes you introduce will be undone the next time that file is generated - see comment on line 5:

Screenshot 2023-10-01 at 11 39 42

So instead the generator must be changed if you want to change anything in this file.

And then there is the nerd-fonts-generated.min.css which is in principle the same file, so it should be changed in tandem. Which is easy if the gerenator is changed.

The generator is https://github.com/ryanoasis/nerd-fonts/blob/master/bin/scripts/generate-css.sh And the place to edit to introduce your change would be the 3 files starting with css- (which are inputs to the script):

Screenshot 2023-10-01 at 11 57 52
Finii commented 11 months ago

Closing for now, we can reopen if you explain.